[PATCH] gnu: Add libzapojit.

[PATCH] gnu: Add libzapojit.

[rennes]

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

Hi,

i attached libzapojit patch for review.

This is a library for accessing SkyDrive and Hotmail, necessary for 
documents manager(GNOME apps).


Thanks in advance

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-libzapojit.patch --]
[-- Type: text/x-diff; name=0001-gnu-Add-libzapojit.patch, Size: 1699 bytes --]

From 2461295d5c4a5a16813053ad433330b43c6e2688 Mon Sep 17 00:00:00 2001
From: Rene Saavedra <rennes@openmailbox.org>
Date: Sat, 20 Feb 2016 16:09:04 -0600
Subject: [PATCH] gnu: Add libzapojit.

* gnu/packages/gnome.scm (libzapojit): New variable.

---
 gnu/packages/gnome.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 363d920..c6ad60a 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -4711,6 +4711,34 @@ can add your own files to the collection.")
                    license:cc-by-sa2.0
                    license:cc-by-sa3.0))))
 
+(define-public libzapojit
+  (package
+    (name "libzapojit")
+    (version "0.0.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://gnome/sources/" name "/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "0zn3s7ryjc3k1abj4k55dr2na844l451nrg9s6cvnnhh569zj99x"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("intltool" ,intltool)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("gnome-online-accounts" ,gnome-online-accounts)
+       ("json-glib" ,json-glib)
+       ("rest" ,rest)))
+    (home-page "https://wiki.gnome.org/Projects/Zapojit")
+    (synopsis "Library for accessing SkyDrive and Hotmail")
+    (description
+     "Libzapojit is a GLib-based library for accessing online service APIs
+using the Microsoft SkyDrive and Hotmail REST protocols.")
+    (license license:lgpl2.1+)))
+
 (define-public gnome
   (package
     (name "gnome")
-- 
2.6.3

Re: [PATCH] gnu: Add libzapojit.

[Leo Famulari]

On Sat, Feb 20, 2016 at 04:25:37PM -0600, rennes@openmailbox.org wrote:
> Hi,
> 
> i attached libzapojit patch for review.

Thanks for the patch!

> 
> This is a library for accessing SkyDrive and Hotmail, necessary for
> documents manager(GNOME apps).

Is the documents manager already packaged?

If so, I assume libzapojit is working for you?

If not, I might want to merge it anyways to encourage further work on
GNOME stuff by everyone :)

> * gnu/packages/gnome.scm (libzapojit): New variable.

[...]

> +    (build-system gnu-build-system)

I can't tell — should it use glib-or-gtk-build-system instead? It seems
to build fine as-is, but I wonder because it uses some GLib stuff.

Looks good aside from these questions.

Re: [PATCH] gnu: Add libzapojit.

[rennes]

On 2016-02-24 19:14, Leo Famulari wrote:
> On Sat, Feb 20, 2016 at 04:25:37PM -0600, rennes@openmailbox.org wrote:
>> Hi,
>> 
>> i attached libzapojit patch for review.
> 
> Thanks for the patch!
> 
>> 
>> This is a library for accessing SkyDrive and Hotmail, necessary for
>> documents manager(GNOME apps).
> 
> Is the documents manager already packaged?
> 
> If so, I assume libzapojit is working for you?
> 
> If not, I might want to merge it anyways to encourage further work on
> GNOME stuff by everyone :)
> 
>> * gnu/packages/gnome.scm (libzapojit): New variable.
> 
> [...]
> 
>> +    (build-system gnu-build-system)
> 
> I can't tell — should it use glib-or-gtk-build-system instead? It seems
> to build fine as-is, but I wonder because it uses some GLib stuff.
> 
> Looks good aside from these questions.

Hi,

GNOME documents is not yet packaged, I started packaging requirements, 
in this sequence. GNOME documents has several requirements not packaged. 
or what is the best strategy to do so?

Thanks

Re: [PATCH] gnu: Add libzapojit.

[Leo Famulari]

On Thu, Feb 25, 2016 at 07:59:51AM -0600, rennes@openmailbox.org wrote:
> On 2016-02-24 19:14, Leo Famulari wrote:
> >On Sat, Feb 20, 2016 at 04:25:37PM -0600, rennes@openmailbox.org wrote:
> >>Hi,
> >>
> >>i attached libzapojit patch for review.
> >
> >Thanks for the patch!
> >
> >>
> >>This is a library for accessing SkyDrive and Hotmail, necessary for
> >>documents manager(GNOME apps).
> >
> >Is the documents manager already packaged?
> >
> >If so, I assume libzapojit is working for you?
> >
> >If not, I might want to merge it anyways to encourage further work on
> >GNOME stuff by everyone :)
> >
> >>* gnu/packages/gnome.scm (libzapojit): New variable.
> >
> >[...]
> >
> >>+    (build-system gnu-build-system)
> >
> >I can't tell — should it use glib-or-gtk-build-system instead? It seems
> >to build fine as-is, but I wonder because it uses some GLib stuff.
> >
> >Looks good aside from these questions.
> 
> Hi,
> 
> GNOME documents is not yet packaged, I started packaging requirements, in
> this sequence. GNOME documents has several requirements not packaged. or
> what is the best strategy to do so?

One strategy is to package the entire dependency graph of GNOME
Documents privately, and then submit them when the whole thing is ready.

You could modify that strategy by sending each package for review as you
go, but without merging them into master until everything is done.

You could modify it again by having us commit each package to master
when it looks good, and then making adjustments later. The benefit of
this is that it's very easy for other people to know how to help you
with this project, for example by packaging some of the dependencies on
their own.

I'm not sure what the best strategy is. It's up to you and anyone else
who comments :) Please advise!

Re: [PATCH] gnu: Add libzapojit.

[Andreas Enge]

On Thu, Feb 25, 2016 at 02:35:25PM -0500, Leo Famulari wrote:
> You could modify it again by having us commit each package to master
> when it looks good, and then making adjustments later. The benefit of
> this is that it's very easy for other people to know how to help you
> with this project, for example by packaging some of the dependencies on
> their own.

I usually use this strategy. It is motivating to see more and more packages
coming in. And I can interrupt my packaging efforts, other people can pick
them up. Or contributors who leave can still leave a trace and add something
useful. And other packages can use new inputs. And it avoids duplicate efforts.
If one notices a mistake in one of the dependencies later, it can easily
be fixed.

Andreas