Re: [PATCH v3] gnu: Add python-psycopg2, python2-psycopg2

[Leo Famulari <leo@famulari.name>]

On Thu, Feb 25, 2016 at 09:53:17AM -0800, Christopher Allan Webber wrote:
> This looks ready to go, though it still lacks a changelog style commit
> message, and it isn't formatted with git format-patch.
> 
> I could commit it myself with that, but I don't know if that would be
> acceptable?  (And should I commit it under my name, or set the author
> name to Danny?  I would certainly want to attribute to Danny.)

It's actually possible to put anything you want in the '--author' field
when committing. There is also '--sign-off', which you can use to
indicate your approval of the author's patch. These options also exist
in some other git tools, notably `git am`.

> 
> If we had a "git format-patch" version of this commit that would be
> easiest.
> 
> Danny Milosavljevic writes:
> 
> > ---
> >  gnu/packages/python.scm | 32 ++++++++++++++++++++++++++++++++
> >  1 file changed, 32 insertions(+)
> >
> > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> > index 55a62a9..35bb1c3 100644
> > --- a/gnu/packages/python.scm
> > +++ b/gnu/packages/python.scm
> > @@ -17,6 +17,7 @@
> >  ;;; Copyright © 2015, 2016 Efraim Flashner <efraim@flashner.co.il>
> >  ;;; Copyright © 2015 Kyle Meyer <kyle@kyleam.com>
> >  ;;; Copyright © 2015 Chris Marusich <cmmarusich@gmail.com>
> > +;;; Copyright © 2016 Danny Milosavljevic <dannym+a@scratchpost.org>
> >  ;;;
> >  ;;; This file is part of GNU Guix.
> >  ;;;
> > @@ -8156,3 +8157,34 @@ introspection of @code{zope.interface} instances in code.")
> >  
> >  (define-public python2-sphinx-repoze-autointerface
> >    (package-with-python2 python-sphinx-repoze-autointerface))
> > +
> > +(define-public python-psycopg2
> > +  (package
> > +    (name "python-psycopg2")
> > +    (version "2.6.1")
> > +    (source
> > +     (origin
> > +       (method url-fetch)
> > +       (uri (pypi-uri "psycopg2" version))
> > +       (sha256
> > +        (base32
> > +         "0k4hshvrwsh8yagydyxgmd0pjm29lwdxkngcq9fzfzkmpsxrmkva"))))
> > +    (build-system python-build-system)
> > +    (arguments
> > +     ;; Tests would require a postgresql database "psycopg2_test"
> > +     ;; and a running postgresql database management service.
> > +     `(#:tests? #f)) ; TODO re-enable after providing a test-db.
> > +    (inputs
> > +     `(("postgresql" ,postgresql))) ; libpq
> > +    (home-page "http://initd.org/psycopg/")
> > +    (synopsis "Python PostgreSQL adapter")
> > +    (description
> > +     "psycopg2 is a thread-safe PostgreSQL adapter that implements DB-API 2.0. ")
> > +    (license lgpl3+)
> > +    (properties `((python2-variant . ,(delay python2-psycopg2))))))
> > +
> > +(define-public python2-psycopg2
> > +  (package
> > +    (inherit (package-with-python2
> > +              (strip-python2-variant python-psycopg2)))
> > +    (native-inputs `(("python2-setuptools" ,python2-setuptools)))))
>