From: Leo Famulari <leo@famulari.name>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: Add libBigWig.
Date: Wed, 24 Feb 2016 20:47:02 -0500 [thread overview]
Message-ID: <20160225014702.GE31607@jasmine> (raw)
In-Reply-To: <idjio1e2i5g.fsf@bimsb-sys02.mdc-berlin.net>
On Wed, Feb 24, 2016 at 05:21:47PM +0100, Ricardo Wurmus wrote:
> Hi Guix,
>
> the description is a little short. Basically, this is a cleaner
> reimplementation of a popular tool/library that is released under a
> non-commercial license. There is little more I can say about it and the
> original description just references that other tool.
>
> Any ideas how to improve this?
If you think it will be clear to the intended audience, I'd say it's
fine.
If "Kent's library" is well-known in the field, would it make sense to
refer to it?
> + (add-before 'install 'create-target-dirs
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let ((out (assoc-ref outputs "out")))
> + (mkdir-p (string-append out "/lib"))
> + (mkdir-p (string-append out "/include"))
> + #t))))))
Does it make sense to upstream this? I understand if it's not worth your
time...
next prev parent reply other threads:[~2016-02-25 1:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 16:21 [PATCH] gnu: Add libBigWig Ricardo Wurmus
2016-02-25 1:47 ` Leo Famulari [this message]
2016-02-25 10:37 ` Ricardo Wurmus
2016-02-25 19:38 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160225014702.GE31607@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).