From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 1/2] gnu: Add python-paste.
Date: Wed, 24 Feb 2016 20:28:28 -0500
Message-ID: <20160225012828.GC31607@jasmine>
References: <87egc38ab7.fsf@dustycloud.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41700)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aYkjL-00012c-UG
	for guix-devel@gnu.org; Wed, 24 Feb 2016 20:28:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aYkjG-0000WF-UO
	for guix-devel@gnu.org; Wed, 24 Feb 2016 20:28:35 -0500
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:42074)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aYkjG-0000W2-JQ
	for guix-devel@gnu.org; Wed, 24 Feb 2016 20:28:30 -0500
Content-Disposition: inline
In-Reply-To: <87egc38ab7.fsf@dustycloud.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Christopher Allan Webber <cwebber@dustycloud.org>
Cc: guix-devel@gnu.org

On Tue, Feb 23, 2016 at 12:02:46PM -0800, Christopher Allan Webber wrote:
> * gnu/packages/python.scm (python-paste, python2-paste): New variables.

Okay.

> * gnu/packages/patches/python-paste-remove-timing-test.patch: New file.

Okay.

> * gnu/packages/patches/python-paste-remove-website-test.patch: New file.

Indeed, a strange test.

[...]

> +(define-public python2-paste
> +  (package
> +    (inherit (strip-python2-variant
> +              (package-with-python2 python-paste)))
> +    (arguments
> +     ;; Tests are back for Python 2!
> +     `(#:python ,python-2
> +                #:tests? #t))))

Is it really necessary to specify python-2 here? How about re-using the
method you used in python2-anyjson?