unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Christopher Allan Webber <cwebber@dustycloud.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/2] gnu: Add python-paste.
Date: Wed, 24 Feb 2016 20:28:28 -0500	[thread overview]
Message-ID: <20160225012828.GC31607@jasmine> (raw)
In-Reply-To: <87egc38ab7.fsf@dustycloud.org>

On Tue, Feb 23, 2016 at 12:02:46PM -0800, Christopher Allan Webber wrote:
> * gnu/packages/python.scm (python-paste, python2-paste): New variables.

Okay.

> * gnu/packages/patches/python-paste-remove-timing-test.patch: New file.

Okay.

> * gnu/packages/patches/python-paste-remove-website-test.patch: New file.

Indeed, a strange test.

[...]

> +(define-public python2-paste
> +  (package
> +    (inherit (strip-python2-variant
> +              (package-with-python2 python-paste)))
> +    (arguments
> +     ;; Tests are back for Python 2!
> +     `(#:python ,python-2
> +                #:tests? #t))))

Is it really necessary to specify python-2 here? How about re-using the
method you used in python2-anyjson?

  reply	other threads:[~2016-02-25  1:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-23 20:02 [PATCH 1/2] gnu: Add python-paste Christopher Allan Webber
2016-02-25  1:28 ` Leo Famulari [this message]
2016-02-25 19:03   ` Christopher Allan Webber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160225012828.GC31607@jasmine \
    --to=leo@famulari.name \
    --cc=cwebber@dustycloud.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).