From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] gnu: Add libzapojit. Date: Wed, 24 Feb 2016 20:14:41 -0500 Message-ID: <20160225011441.GA31607@jasmine> References: <58ba5d1146752af014230febb2fd2c49@openmailbox.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34931) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYkVx-0005WQ-Q0 for guix-devel@gnu.org; Wed, 24 Feb 2016 20:14:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYkVu-00021N-Jb for guix-devel@gnu.org; Wed, 24 Feb 2016 20:14:45 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:41066) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYkVu-00020s-Fn for guix-devel@gnu.org; Wed, 24 Feb 2016 20:14:42 -0500 Content-Disposition: inline In-Reply-To: <58ba5d1146752af014230febb2fd2c49@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: rennes@openmailbox.org Cc: guix-devel@gnu.org On Sat, Feb 20, 2016 at 04:25:37PM -0600, rennes@openmailbox.org wrote: > Hi, > > i attached libzapojit patch for review. Thanks for the patch! > > This is a library for accessing SkyDrive and Hotmail, necessary for > documents manager(GNOME apps). Is the documents manager already packaged? If so, I assume libzapojit is working for you? If not, I might want to merge it anyways to encourage further work on GNOME stuff by everyone :) > * gnu/packages/gnome.scm (libzapojit): New variable. [...] > + (build-system gnu-build-system) I can't tell — should it use glib-or-gtk-build-system instead? It seems to build fine as-is, but I wonder because it uses some GLib stuff. Looks good aside from these questions.