libwnck

libwnck

[Andreas Enge]

Hello,

we have the following in gnome.scm:
$ guix package -A libwnck
libwnck	2.30.7	out	gnu/packages/gnome.scm:1464:2
libwnck	3.14.0	out	gnu/packages/gnome.scm:1435:2

However, the first one is internally assigned to the variable "libwnck-1".
I assume that someone got inspired by another case where the "-1" is actually
a version number. Is it okay if I rename it to "libwnck-2"?

Andreas

Re: libwnck

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 1309 bytes --]

On Tue, 23 Feb 2016 12:31:38 +0100
Andreas Enge <andreas@enge.fr> wrote:

> Hello,
> 
> we have the following in gnome.scm:
> $ guix package -A libwnck
> libwnck	2.30.7	out	gnu/packages/gnome.scm:1464:2
> libwnck	3.14.0	out	gnu/packages/gnome.scm:1435:2
> 
> However, the first one is internally assigned to the variable "libwnck-1".
> I assume that someone got inspired by another case where the "-1" is actually
> a version number. Is it okay if I rename it to "libwnck-2"?
> 
> Andreas
> 
> 

efraim@debian-netbook:~$ guix refresh -l libwnck-1
guix refresh: error: libwnck: package not found for version 1
efraim@debian-netbook:~$ guix refresh -l libwnck-2
Building the following package would ensure 1 dependent packages are rebuilt: xfce-4.12.0
efraim@debian-netbook:~$ guix refresh -l libwnck-3
Building the following package would ensure 1 dependent packages are rebuilt: gnome-3.18.3

Looks like a good idea to me. Finding specific non-latest version can be
hard, and having the 2.x version having the same string for packaging as for
searching should help.


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: libwnck

[Fabian Harfert]

On Tue, 23 Feb 2016 12:31:38 +0100
Andreas Enge <andreas@enge.fr> wrote:

> Hello,
> 
> we have the following in gnome.scm:
> $ guix package -A libwnck
> libwnck	2.30.7	out	gnu/packages/gnome.scm:1464:2
> libwnck	3.14.0	out	gnu/packages/gnome.scm:1435:2
> 
> However, the first one is internally assigned to the variable
> "libwnck-1". I assume that someone got inspired by another case where
> the "-1" is actually a version number. Is it okay if I rename it to
> "libwnck-2"?
> 
> Andreas
> 
> 

Hello,

the name libwnck-1 is right. The library files have this name and the
pkg-config file refers to that. This is because it uses Gtk+ 2.x and
has a different API than libwnck-3. I don't know why they chose this
versioning, but it's their decision.

Fabian

Re: libwnck

[Andreas Enge]

On Wed, Feb 24, 2016 at 04:06:18PM +0100, Fabian Harfert wrote:
> the name libwnck-1 is right. The library files have this name and the
> pkg-config file refers to that. This is because it uses Gtk+ 2.x and
> has a different API than libwnck-3. I don't know why they chose this
> versioning, but it's their decision.

Well, these are the sonames, which need not be related to the program version.
A package with a given version may ship arbitrary libraries with arbitrary
sonames. For instance, gmp-6.1 and gmp-6.0 ship libgmp.so.10 and
libgmpxx.so.4.

Nevertheless, we still call all variables gmp and gmp-6.0, respectively.

So here we should also use libwnck-2. Notice that the variable name is
something that humans edit, whereas we need not care about sonames that
are handled by some magic.

Andreas

Re: libwnck

[Fabian Harfert]

On Wed, 24 Feb 2016 16:17:41 +0100
Andreas Enge <andreas@enge.fr> wrote:

> On Wed, Feb 24, 2016 at 04:06:18PM +0100, Fabian Harfert wrote:
> > the name libwnck-1 is right. The library files have this name and
> > the pkg-config file refers to that. This is because it uses Gtk+
> > 2.x and has a different API than libwnck-3. I don't know why they
> > chose this versioning, but it's their decision.  
> 
> Well, these are the sonames, which need not be related to the program
> version. A package with a given version may ship arbitrary libraries
> with arbitrary sonames. For instance, gmp-6.1 and gmp-6.0 ship
> libgmp.so.10 and libgmpxx.so.4.
> 
> Nevertheless, we still call all variables gmp and gmp-6.0,
> respectively.
> 
> So here we should also use libwnck-2. Notice that the variable name is
> something that humans edit, whereas we need not care about sonames
> that are handled by some magic.
> 
> Andreas
> 

Ok, just saw that after I read your mail.

Re: libwnck

[Andreas Enge]

On Tue, Feb 23, 2016 at 12:31:38PM +0100, Andreas Enge wrote:
> However, the first one is internally assigned to the variable "libwnck-1".
> I assume that someone got inspired by another case where the "-1" is actually
> a version number. Is it okay if I rename it to "libwnck-2"?

Done in commit dbb7a08.

Andreas