From: Leo Famulari <leo@famulari.name>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: Version numbers for VCS snapshots
Date: Sat, 20 Feb 2016 23:35:15 -0500 [thread overview]
Message-ID: <20160221043515.GA17164@jasmine> (raw)
In-Reply-To: <87fuxqwsm7.fsf@gnu.org>
On Thu, Jan 21, 2016 at 10:05:36PM +0100, Ludovic Courtès wrote:
> Leo Famulari <leo@famulari.name> skribis:
>
> > On Thu, Jan 21, 2016 at 10:40:41AM +0100, Ricardo Wurmus wrote:
> >>
> >> Leo Famulari <leo@famulari.name> writes:
> >>
> >> > That sounds good to me. There was some discussion of how much of the
> >> > hash to keep here:
> >> > http://lists.gnu.org/archive/html/guix-devel/2015-12/msg00136.html
> >> >
> >> > I like this method that I've seen in some of the packages, because it
> >> > keeps the version tidy while preserving the full hash:
> >> >
> >> > --8<---------------cut here---------------start------------->8---
> >> > (define-public hello
> >> > (let ((commit "e8e46123cfe62170a2f7f79db6b471b66ae36947"))
> >> > (package
> >> > (name "hello")
> >> > (version (string-append "2.10-1" (string-take commit 8)))
> >> > (source (origin
> >> > (method git-fetch)
> >> > (uri (git-reference
> >> > (url "git://git.sv.gnu.org/hello.git")
> >> > (commit commit)))
> >> > (sha256
> >> > [...]
> >> > --8<---------------cut here---------------end--------------->8---
> >>
> >> I like this approach (though I’ve been taking 9 characters of the commit
> >> ;)).
> >
> > I like 10 but I wanted to match your example upthread ;)
>
> I prefer 7! This is how Git usually truncates SHA1s, so it can’t be wrong.
I stumbled across this email earlier, which reminded me of this
discussion about hash lengths:
https://lkml.org/lkml/2010/10/28/287
There are currently 13 7-character hash collisions in Guix's git repo:
$ git rev-list --objects --all | cut -c1-7 | sort | uniq -dc
2 0d2b24c
2 11e0632
2 1f3ab8d
2 229bd6c
2 7c4a7b7
2 9ff8b63
2 aa27b56
2 c10c562
2 d96cdce
2 dab4329
2 dc27d1c
2 ea119a2
2 f56cc27
next prev parent reply other threads:[~2016-02-21 4:35 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-09 21:26 New CLI syntax for package version Ludovic Courtès
2016-01-09 22:52 ` Andreas Enge
2016-01-10 8:32 ` Ricardo Wurmus
2016-01-11 3:37 ` Christopher Allan Webber
2016-01-11 15:48 ` Eric Bavier
2016-01-12 7:50 ` Ricardo Wurmus
2016-01-12 9:26 ` Version numbers for VCS snapshots Ludovic Courtès
2016-01-21 4:51 ` Ben Woodcroft
2016-01-21 6:22 ` Leo Famulari
2016-01-21 9:40 ` Ricardo Wurmus
2016-01-21 18:44 ` Leo Famulari
2016-01-21 21:05 ` Ludovic Courtès
2016-02-21 4:35 ` Leo Famulari [this message]
2016-02-21 9:17 ` Alex Kost
2016-02-21 22:52 ` Leo Famulari
2016-02-22 0:09 ` Christopher Allan Webber
2016-02-23 11:53 ` Ludovic Courtès
2016-01-21 9:44 ` Ricardo Wurmus
2016-01-21 21:25 ` Ludovic Courtès
2016-01-21 22:02 ` Ricardo Wurmus
2016-01-23 22:00 ` Ludovic Courtès
2016-01-23 22:07 ` Ricardo Wurmus
2016-01-24 23:12 ` Ludovic Courtès
2016-01-21 22:08 ` Eric Bavier
2016-01-21 22:23 ` Jookia
2016-01-22 9:35 ` Andy Wingo
2016-01-22 12:31 ` Ricardo Wurmus
2016-01-23 21:51 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160221043515.GA17164@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).