From: Andreas Enge <andreas@enge.fr>
To: Fabian Harfert <fhmgufs@web.de>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/7] gnu: Add mate-polkit.
Date: Sat, 20 Feb 2016 14:41:17 +0100 [thread overview]
Message-ID: <20160220134117.GA6934@solar> (raw)
In-Reply-To: <1455912381-25148-1-git-send-email-fhmgufs@web.de>
Hello,
before considering more mate packages, I would like to get back to discussing
the existing ones; as I am not knowledgeable about desktop packages, I must
admit I did not look at them too closely before. So maybe my comments can
also be disregarded, but it would be good if someone more expert could
chime in.
First of all, the build system. Since usually there are inputs glib and gtk+,
would it not be more appropriate to use glib-or-gtk-build-system?
Second, there are lots of propagated inputs. Are these really needed?
It is a bit strange that a library like libmateweather should need such a
propagation; normally our runpath magic should have rewritten all references
to input libraries.
If propagations are necessary, the reason should be added as a comment, for
instance as for gnome-desktop:
(propagated-inputs
;; Required by gnome-desktop-3.0.pc.
`(("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
("gtk+" ,gtk+)))
The .pc file of libmateweather indeed has the following lines:
Requires: glib-2.0 gobject-2.0 gdk-pixbuf-2.0 gtk+-2.0 gio-2.0
Requires.private: libxml-2.0 libsoup-2.4
Also, weather.h contains
#include <gdk-pixbuf/gdk-pixbuf.h>
So it looks as if propagation is needed here.
What do you think?
Andreas
next prev parent reply other threads:[~2016-02-20 13:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 20:06 [PATCH 1/7] gnu: Add mate-polkit Fabian Harfert
2016-02-19 20:06 ` [PATCH 2/7] gnu: Add libmatekbd Fabian Harfert
2016-02-19 20:06 ` [PATCH 3/7] gnu: Add libmatemixer Fabian Harfert
2016-02-19 20:06 ` [PATCH 4/7] gnu: Add mate-settings-daemon Fabian Harfert
2016-02-19 20:06 ` [PATCH 5/7] gnu: Add mate-session-manager Fabian Harfert
2016-02-19 20:06 ` [PATCH 6/7] gnu: Add marco Fabian Harfert
2016-02-19 20:06 ` [PATCH 7/7] gnu: Add mate-panel Fabian Harfert
2016-02-20 13:41 ` Andreas Enge [this message]
2016-02-20 17:17 ` [PATCH 1/7] gnu: Add mate-polkit Fabian Harfert
2016-02-21 15:26 ` Andreas Enge
2016-02-20 17:30 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160220134117.GA6934@solar \
--to=andreas@enge.fr \
--cc=fhmgufs@web.de \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).