unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Christopher Baines <mail@cbaines.net>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/2] gnu: Add python-mpd2
Date: Thu, 18 Feb 2016 17:51:07 -0500	[thread overview]
Message-ID: <20160218225107.GD9390@jasmine> (raw)
In-Reply-To: <56C640CC.1080105@cbaines.net>

On Thu, Feb 18, 2016 at 10:08:12PM +0000, Christopher Baines wrote:
> On 18/02/16 22:00, Leo Famulari wrote:
> > On Thu, Feb 18, 2016 at 09:26:53PM +0000, Christopher Baines wrote:
> >> * gnu/packages/python.scm (python-mpd2): New variable
> >> * gnu/packages/python.scm Import lgpl3.
> > 
> > I actually have a patch for this in a WIP tree (attached). Based on the
> > differences, and the fact that I have already made the changes requested
> > below, I think my version of the patch should be used. My patch also
> > adds a python-2 version; when possible, it's preferred to add both
> > versions.
> > 
> > What do you think?
> 
> That's fine by me.
> 
> >> +    (build-system python-build-system)
> >> +    (arguments
> >> +     `(#:phases
> >> +       (alist-replace
> >> +        'check
> >> +        (lambda _ (zero? (system* "python" "mpd_test.py")))
> >> +        %standard-phases)))
> >> +    (inputs
> >> +      `(("python-setuptools" ,python-setuptools)
> >> +        ("python-mock" ,python-mock)
> >> +        ("python-unittest2" ,python-unittest2)))
> > 
> > I don't believe that unittest2 is needed. I can build both
> > python-variants without it.
> 
> From looking at the source, I think its only needed for running the
> tests with python2.6 [1].
> 
> 1:
> https://github.com/Mic92/python-mpd2/blob/6818984462552dbc7ca85d014f5cf9a8a1e81aec/mpd_test.py#L14
> 
> > Setuptools is only needed for the python2-variant.
> > 
> > And, I think mock is only needed at build-time, so it would be a
> > native-input.
> 
> I though native inputs had something to do with architectures, which I
> guess won't matter here, so why is it not just an input?

The "native" part refers to the architecture of the build machine, which
is important when cross-compiling.

A side benefit is that end users shouldn't have to download
native-inputs when substituting. In some cases, that can save a lot of
bandwidth. So, we make build-time-only dependencies native-inputs. In
practice, I've seen packages end up with references to native-inputs in
their output, but that's not optimal.

Semi-relevant discussion of the problems of propagated-inputs:
http://lists.gnu.org/archive/html/guix-devel/2016-02/msg00810.html

  reply	other threads:[~2016-02-18 22:51 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-18 21:26 [PATCH] Add sonata and python-mpd2 Christopher Baines
2016-02-18 21:26 ` [PATCH 1/2] gnu: Add python-mpd2 Christopher Baines
2016-02-18 22:00   ` Leo Famulari
2016-02-18 22:08     ` Christopher Baines
2016-02-18 22:51       ` Leo Famulari [this message]
2016-02-18 21:26 ` [PATCH 2/2] gnu: Add sonata Christopher Baines
2016-02-18 23:57   ` Leo Famulari
2016-02-20 11:18     ` Andreas Enge
2016-02-20 12:37       ` Leo Famulari
2016-02-20 18:49   ` Thompson, David
2016-02-29  7:18     ` Ricardo Wurmus
2016-09-10 11:31 ` [PATCH] " Christopher Baines
2016-09-10 11:31   ` Christopher Baines
2016-09-10 18:08     ` Leo Famulari
2016-09-11 10:00       ` Christopher Baines
2016-09-11 10:00         ` Christopher Baines
2016-09-11 15:08           ` Leo Famulari
2016-09-12 16:04             ` Thompson, David
2016-09-11 17:01           ` Alex Kost
2016-09-11 18:11             ` Leo Famulari
2016-09-11 18:34             ` Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160218225107.GD9390@jasmine \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).