From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH 3/3] gnu: Add vcsh Date: Thu, 18 Feb 2016 16:26:26 -0500 Message-ID: <20160218212626.GA1053@jasmine> References: <1455379675-27516-1-git-send-email-mail@cbaines.net> <1455379675-27516-4-git-send-email-mail@cbaines.net> <20160213224108.GC1176@jasmine> <56C0E530.9010604@cbaines.net> <20160217181107.GA31074@solar> <56C4C2FC.7070107@cbaines.net> <20160218001144.GA26345@jasmine> <20160218200100.GC3445@solar> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39621) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWW5r-00058C-0O for guix-devel@gnu.org; Thu, 18 Feb 2016 16:26:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWW5m-0007C9-0Q for guix-devel@gnu.org; Thu, 18 Feb 2016 16:26:34 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:56102) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWW5l-0007By-RH for guix-devel@gnu.org; Thu, 18 Feb 2016 16:26:29 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 8404820CEE for ; Thu, 18 Feb 2016 16:26:29 -0500 (EST) Content-Disposition: inline In-Reply-To: <20160218200100.GC3445@solar> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Andreas Enge Cc: guix-devel@gnu.org On Thu, Feb 18, 2016 at 09:01:00PM +0100, Andreas Enge wrote: > On Wed, Feb 17, 2016 at 07:11:44PM -0500, Leo Famulari wrote: > > I missed this earlier. We don't usually propagate this sort of "end-user > > program" dependencies. For example rsync does not propagate ssh; the > > user must install ssh. [0] > > I think the cleanest approach would be to patch all calls to "git" in > the vcsh shell script by calls to "/gnu/store/xxxx-git-.../bin/git", > where the base name is taken as "(assoc-ref %build-inputs "git")" or the like. > > What do you think? Indeed, this sounds like a clean solution. In that case, git would be a plain input. > > It might be as simple as a call in a phase to "substitute*", replacing > "git " by the path+" ". The script is a bit annoying in that it scatters > calls to git all over the place. It would be cleaner to define "GIT=git" > at the start of the file, and then always call "$(GIT)". Maybe that is > something to suggest to the upstream author? Since 'git' is such a short string, the possibility of "mis-patching" when performing the string substitution seems a little too high. What do you think?