unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Andreas Enge <andreas@enge.fr>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 3/3] gnu: Add vcsh
Date: Thu, 18 Feb 2016 16:26:26 -0500	[thread overview]
Message-ID: <20160218212626.GA1053@jasmine> (raw)
In-Reply-To: <20160218200100.GC3445@solar>

On Thu, Feb 18, 2016 at 09:01:00PM +0100, Andreas Enge wrote:
> On Wed, Feb 17, 2016 at 07:11:44PM -0500, Leo Famulari wrote:
> > I missed this earlier. We don't usually propagate this sort of "end-user
> > program" dependencies. For example rsync does not propagate ssh; the
> > user must install ssh. [0]
> 
> I think the cleanest approach would be to patch all calls to "git" in
> the vcsh shell script by calls to "/gnu/store/xxxx-git-.../bin/git",
> where the base name is taken as "(assoc-ref %build-inputs "git")" or the like.
> 
> What do you think?

Indeed, this sounds like a clean solution. In that case, git would be a
plain input.

> 
> It might be as simple as a call in a phase to "substitute*", replacing
> "git " by the path+" ". The script is a bit annoying in that it scatters
> calls to git all over the place. It would be cleaner to define "GIT=git"
> at the start of the file, and then always call "$(GIT)". Maybe that is
> something to suggest to the upstream author?

Since 'git' is such a short string, the possibility of "mis-patching"
when performing the string substitution seems a little too high. What do
you think?

  parent reply	other threads:[~2016-02-18 21:26 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-13 16:07 [PATCH] gnu: Add vcsh and perl-shell-command Christopher Baines
2016-02-13 16:07 ` [PATCH 1/3] gnu: Add perl-shell-command Christopher Baines
2016-02-13 22:42   ` Leo Famulari
2016-02-13 16:07 ` [PATCH 2/3] gnu: Don't use guix build utils Christopher Baines
2016-02-13 22:39   ` Leo Famulari
2016-02-17 18:28     ` Christopher Baines
2016-02-18  0:15       ` Leo Famulari
2016-02-18 19:55         ` Andreas Enge
2016-02-18 19:59           ` Christopher Baines
2016-02-18 20:16             ` Andreas Enge
2016-02-18 21:13               ` Christopher Baines
2016-02-18 21:37                 ` Andreas Enge
2016-02-13 16:07 ` [PATCH 3/3] gnu: Add vcsh Christopher Baines
2016-02-13 22:41   ` Leo Famulari
2016-02-14 20:36     ` Christopher Baines
2016-02-17 18:11       ` Andreas Enge
2016-02-17 18:59         ` Christopher Baines
2016-02-18  0:11           ` Leo Famulari
2016-02-18  0:27             ` Christopher Baines
2016-02-18 20:01             ` Andreas Enge
2016-02-18 21:04               ` Christopher Baines
2016-02-18 21:26               ` Leo Famulari [this message]
2016-02-18 21:32                 ` Christopher Baines
2016-02-18 21:39                   ` Andreas Enge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160218212626.GA1053@jasmine \
    --to=leo@famulari.name \
    --cc=andreas@enge.fr \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).