From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andreas Enge <andreas@enge.fr>
Subject: Re: [PATCH 3/3] gnu: Add vcsh
Date: Thu, 18 Feb 2016 21:01:00 +0100
Message-ID: <20160218200100.GC3445@solar>
References: <1455379675-27516-1-git-send-email-mail@cbaines.net>
	<1455379675-27516-4-git-send-email-mail@cbaines.net>
	<20160213224108.GC1176@jasmine> <56C0E530.9010604@cbaines.net>
	<20160217181107.GA31074@solar> <56C4C2FC.7070107@cbaines.net>
	<20160218001144.GA26345@jasmine>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52595)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1aWUlD-0004Fq-Ts
	for guix-devel@gnu.org; Thu, 18 Feb 2016 15:01:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1aWUl8-0005XT-20
	for guix-devel@gnu.org; Thu, 18 Feb 2016 15:01:11 -0500
Received: from mailrelay2.public.one.com ([91.198.169.125]:27084)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1aWUl7-0005XA-Oc
	for guix-devel@gnu.org; Thu, 18 Feb 2016 15:01:06 -0500
Content-Disposition: inline
In-Reply-To: <20160218001144.GA26345@jasmine>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org

On Wed, Feb 17, 2016 at 07:11:44PM -0500, Leo Famulari wrote:
> I missed this earlier. We don't usually propagate this sort of "end-user
> program" dependencies. For example rsync does not propagate ssh; the
> user must install ssh. [0]

I think the cleanest approach would be to patch all calls to "git" in
the vcsh shell script by calls to "/gnu/store/xxxx-git-.../bin/git",
where the base name is taken as "(assoc-ref %build-inputs "git")" or the like.

What do you think?

It might be as simple as a call in a phase to "substitute*", replacing
"git " by the path+" ". The script is a bit annoying in that it scatters
calls to git all over the place. It would be cleaner to define "GIT=git"
at the start of the file, and then always call "$(GIT)". Maybe that is
something to suggest to the upstream author?

Andreas