From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Enge Subject: Re: [PATCH 2/3] gnu: Don't use guix build utils Date: Thu, 18 Feb 2016 20:55:05 +0100 Message-ID: <20160218195505.GB3445@solar> References: <1455379675-27516-1-git-send-email-mail@cbaines.net> <1455379675-27516-3-git-send-email-mail@cbaines.net> <20160213223918.GB1176@jasmine> <56C4BBC2.7070103@cbaines.net> <20160218001523.GB26345@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWUfQ-0008EP-KN for guix-devel@gnu.org; Thu, 18 Feb 2016 14:55:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWUfN-00032R-Dw for guix-devel@gnu.org; Thu, 18 Feb 2016 14:55:12 -0500 Received: from mailrelay6.public.one.com ([91.198.169.200]:55403) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWUfN-000327-3j for guix-devel@gnu.org; Thu, 18 Feb 2016 14:55:09 -0500 Content-Disposition: inline In-Reply-To: <20160218001523.GB26345@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Leo Famulari Cc: guix-devel@gnu.org On Wed, Feb 17, 2016 at 07:15:23PM -0500, Leo Famulari wrote: > The commit that removes the module only makes sense in the context of > adding vcsh. It's analogous to adding a module that is required for a > new package, and that is done in a single commit. So, I think it's > better to squash the commits. Yes, I agree it could/should be done at the same time as adding vcsh. First of all, we will need to get perl-shell-command in; I do not find the patch any more. Leo, if you still have it and it looks good, could you please push it? Otherwise, Christopher, could you resend it? Sorry for my lack of organisation, Andreas