unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] wxwidgets: enable extended regexps
Date: Mon, 15 Feb 2016 17:04:09 -0500	[thread overview]
Message-ID: <20160215220409.GC22965@jasmine> (raw)
In-Reply-To: <20160215172839.6e00fcd9@scratchpost.org>

On Mon, Feb 15, 2016 at 05:28:39PM +0100, Danny Milosavljevic wrote:
> Hi,
> 
> the following patch enables "extended" regexps as required by kicad.
> It could conceivably inadvertedly change behaviour of other wxwidgets apps. 
> What do you think? Is this the right way?

Can you test that some of these other apps still work with this change?

> 
> diff --git a/gnu/packages/wxwidgets.scm b/gnu/packages/wxwidgets.scm
> index b49fb2f..65adfc1 100644
> --- a/gnu/packages/wxwidgets.scm
> +++ b/gnu/packages/wxwidgets.scm
> @@ -61,7 +61,7 @@
>       `(("pkg-config" ,pkg-config)))
>      (arguments
>       '(#:configure-flags
> -       '("--with-regex=sys" "--with-libmspack" "--with-sdl")
> +       '("--with-regex" "--with-libmspack" "--with-sdl")
>         #:make-flags
>         (list (string-append "LDFLAGS=-Wl,-rpath="
>                              (assoc-ref %outputs "out") "/lib"))
> 

  reply	other threads:[~2016-02-15 22:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-15 16:28 [PATCH] wxwidgets: enable extended regexps Danny Milosavljevic
2016-02-15 22:04 ` Leo Famulari [this message]
2016-02-15 22:07   ` Andreas Enge
2016-02-15 22:47     ` Thompson, David
2016-02-16 19:42       ` Danny Milosavljevic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160215220409.GC22965@jasmine \
    --to=leo@famulari.name \
    --cc=dannym@scratchpost.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).