From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: Inherit inputs when unnecessary in these python2 packages?
Date: Sun, 14 Feb 2016 14:09:35 -0500
Message-ID: <20160214190935.GB18708@jasmine>
References: <87twlct53f.fsf@dustycloud.org>
 <20160214144832.GG6684@debian>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53440)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aV235-0007y4-5W
	for guix-devel@gnu.org; Sun, 14 Feb 2016 14:09:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aV230-00081v-5Q
	for guix-devel@gnu.org; Sun, 14 Feb 2016 14:09:35 -0500
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:42901)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aV230-00081q-2F
	for guix-devel@gnu.org; Sun, 14 Feb 2016 14:09:30 -0500
Content-Disposition: inline
In-Reply-To: <20160214144832.GG6684@debian>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Andreas Enge <andreas@enge.fr>
Cc: guix-devel@gnu.org

On Sun, Feb 14, 2016 at 03:48:32PM +0100, Andreas Enge wrote:
> On Sat, Feb 13, 2016 at 06:10:17PM -0800, Christopher Allan Webber wrote:
> > >     (native-inputs
> > >      `(("python-setuptools-scm" ,python-setuptools-scm)))
> > > 
> > > (define-public python2-execnet
> > >   (package
> > >     (inherit (package-with-python2
> > >               (strip-python2-variant python-execnet)))
> > >     (inputs
> > >      `(("python2-setuptools" ,python2-setuptools)))))
> > 
> > As you can see, there is no inputs on python-execnet, so it's not
> > necessary to include the inputs.  However, if (inputs) were added in the
> > future, this could lead to a developer mistakenly forgetting to change
> > the python2 variant.
> 
> This looks suspicious; should the python2-setuptools not also be a
> native input? Then accidentally the problem you mention would also
> disappear.

Yes, I pointed this out to Christopher after missing it in my review. It
should be fixed at some point.