From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Enge Subject: Re: [PATCH] gnu: Add genometools. Date: Sun, 14 Feb 2016 16:47:10 +0100 Message-ID: <20160214154710.GA8633@debian> References: <1455461782-24162-1-git-send-email-justus@gnupg.org> <1455461782-24162-2-git-send-email-justus@gnupg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45895) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUytL-0003ku-0l for guix-devel@gnu.org; Sun, 14 Feb 2016 10:47:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aUytH-00013D-Pb for guix-devel@gnu.org; Sun, 14 Feb 2016 10:47:18 -0500 Received: from mailrelay6.public.one.com ([91.198.169.200]:21730) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUytH-000137-Ca for guix-devel@gnu.org; Sun, 14 Feb 2016 10:47:15 -0500 Content-Disposition: inline In-Reply-To: <1455461782-24162-2-git-send-email-justus@gnupg.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Justus Winter Cc: guix-devel@gnu.org Hello, On Sun, Feb 14, 2016 at 03:56:21PM +0100, Justus Winter wrote: > this is my first package, please be nice ;) we always are :-) The package looks very nice, I only have a few minor comments. On Sun, Feb 14, 2016 at 03:56:22PM +0100, Justus Winter wrote: > * gnu-system.am (dist_patch_DATA): Add new patch. > * gnu/packages/bioinformatics.scm (genometools): New package. This should read "new variable". > + #:phases (alist-delete 'configure %standard-phases))) You copy-pasted from an old-fashioned package here; I would suggest to use the more modern modify-phases syntax. > + (synopsis "Versatile open source genome analysis software") > + (description > + "The GenomeTools genome analysis system is a free collection of > +bioinformatics tools (in the realm of genome informatics) combined > +into a single binary named gt. It is based on a C library named > +'libgenometools' which consists of several modules.") Ah, do not use the word "open source"! :-) Actually, we drop all occurrences of "open source" and "free", since it is understood in the context of Guix. Maybe the description could be a bit more, hm, descriptive? Instead of giving the names of the commands, rather speak more about the functionality? Thanks for your contribution, and welcome aboard! Andreas