From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Enge Subject: Re: Inherit inputs when unnecessary in these python2 packages? Date: Sun, 14 Feb 2016 15:48:32 +0100 Message-ID: <20160214144832.GG6684@debian> References: <87twlct53f.fsf@dustycloud.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33114) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUxya-0004qJ-Kh for guix-devel@gnu.org; Sun, 14 Feb 2016 09:48:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aUxyX-0004su-7X for guix-devel@gnu.org; Sun, 14 Feb 2016 09:48:40 -0500 Received: from mailrelay2.public.one.com ([91.198.169.125]:45104) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUxyW-0004sq-SO for guix-devel@gnu.org; Sun, 14 Feb 2016 09:48:37 -0500 Content-Disposition: inline In-Reply-To: <87twlct53f.fsf@dustycloud.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Christopher Allan Webber Cc: guix-devel@gnu.org On Sat, Feb 13, 2016 at 06:10:17PM -0800, Christopher Allan Webber wrote: > > (native-inputs > > `(("python-setuptools-scm" ,python-setuptools-scm))) > > > > (define-public python2-execnet > > (package > > (inherit (package-with-python2 > > (strip-python2-variant python-execnet))) > > (inputs > > `(("python2-setuptools" ,python2-setuptools))))) > > As you can see, there is no inputs on python-execnet, so it's not > necessary to include the inputs. However, if (inputs) were added in the > future, this could lead to a developer mistakenly forgetting to change > the python2 variant. This looks suspicious; should the python2-setuptools not also be a native input? Then accidentally the problem you mention would also disappear. Andreas