From: Andreas Enge <andreas@enge.fr>
To: Christopher Allan Webber <cwebber@dustycloud.org>
Cc: guix-devel@gnu.org
Subject: Re: Inherit inputs when unnecessary in these python2 packages?
Date: Sun, 14 Feb 2016 15:48:32 +0100 [thread overview]
Message-ID: <20160214144832.GG6684@debian> (raw)
In-Reply-To: <87twlct53f.fsf@dustycloud.org>
On Sat, Feb 13, 2016 at 06:10:17PM -0800, Christopher Allan Webber wrote:
> > (native-inputs
> > `(("python-setuptools-scm" ,python-setuptools-scm)))
> >
> > (define-public python2-execnet
> > (package
> > (inherit (package-with-python2
> > (strip-python2-variant python-execnet)))
> > (inputs
> > `(("python2-setuptools" ,python2-setuptools)))))
>
> As you can see, there is no inputs on python-execnet, so it's not
> necessary to include the inputs. However, if (inputs) were added in the
> future, this could lead to a developer mistakenly forgetting to change
> the python2 variant.
This looks suspicious; should the python2-setuptools not also be a
native input? Then accidentally the problem you mention would also
disappear.
Andreas
next prev parent reply other threads:[~2016-02-14 14:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-14 2:10 Inherit inputs when unnecessary in these python2 packages? Christopher Allan Webber
2016-02-14 3:19 ` Leo Famulari
2016-02-14 14:48 ` Andreas Enge [this message]
2016-02-14 19:09 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160214144832.GG6684@debian \
--to=andreas@enge.fr \
--cc=cwebber@dustycloud.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).