From: Leo Famulari <leo@famulari.name>
To: Christopher Baines <mail@cbaines.net>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 3/3] gnu: Add vcsh
Date: Sat, 13 Feb 2016 17:41:08 -0500 [thread overview]
Message-ID: <20160213224108.GC1176@jasmine> (raw)
In-Reply-To: <1455379675-27516-4-git-send-email-mail@cbaines.net>
On Sat, Feb 13, 2016 at 04:07:55PM +0000, Christopher Baines wrote:
> * gnu/packages/version-control.scm (vcsh): New variable.
[...]
> + (arguments
> + `(#:phases (modify-phases %standard-phases
> + (delete 'configure)
> + (delete 'check)
> + (delete 'build))
Can you add comments explaining why the check and build phases are
deleted?
For the former, it can be as simple as "no test suite".
I assume the build phase is replaced by the install phase; the comment
can say something like that if it's the case.
> + #:make-flags (list (string-append "PREFIX=" %output))))
> + (native-inputs
> + `(("which" ,which)))
> + (inputs
> + `(("perl-shell-command" ,perl-shell-command)
> + ("perl-test-most" ,perl-test-most)))
> + (propagated-inputs
> + `(("git" ,git)))
> + (home-page "https://github.com/RichiH/vcsh")
> + (synopsis "Version control system for $HOME")
> + (description
> + "vcsh provides the @code{vcsh} command, which allows you to maintain
> +several Git repositories in one single directory. This can be useful when
> +using version control for files in your home directory, as it allows for
> +the separation of the files in to different repositories, for example you
> +may keep your bash configuration in a separate Git repository from your
> +emacs configuration.")
> + (license gpl2+)))
> --
> 2.7.0
>
>
next prev parent reply other threads:[~2016-02-13 22:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-13 16:07 [PATCH] gnu: Add vcsh and perl-shell-command Christopher Baines
2016-02-13 16:07 ` [PATCH 1/3] gnu: Add perl-shell-command Christopher Baines
2016-02-13 22:42 ` Leo Famulari
2016-02-13 16:07 ` [PATCH 2/3] gnu: Don't use guix build utils Christopher Baines
2016-02-13 22:39 ` Leo Famulari
2016-02-17 18:28 ` Christopher Baines
2016-02-18 0:15 ` Leo Famulari
2016-02-18 19:55 ` Andreas Enge
2016-02-18 19:59 ` Christopher Baines
2016-02-18 20:16 ` Andreas Enge
2016-02-18 21:13 ` Christopher Baines
2016-02-18 21:37 ` Andreas Enge
2016-02-13 16:07 ` [PATCH 3/3] gnu: Add vcsh Christopher Baines
2016-02-13 22:41 ` Leo Famulari [this message]
2016-02-14 20:36 ` Christopher Baines
2016-02-17 18:11 ` Andreas Enge
2016-02-17 18:59 ` Christopher Baines
2016-02-18 0:11 ` Leo Famulari
2016-02-18 0:27 ` Christopher Baines
2016-02-18 20:01 ` Andreas Enge
2016-02-18 21:04 ` Christopher Baines
2016-02-18 21:26 ` Leo Famulari
2016-02-18 21:32 ` Christopher Baines
2016-02-18 21:39 ` Andreas Enge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160213224108.GC1176@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).