From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: gnu: Add python-wtforms. Date: Sat, 13 Feb 2016 17:23:07 -0500 Message-ID: <20160213222307.GA1127@jasmine> References: <87pow190jn.fsf@dustycloud.org> <87io1t8pho.fsf@dustycloud.org> <87ziv4tgzt.fsf@dustycloud.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="qMm9M+Fa2AknHoGS" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55713) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUiat-0005ZK-T2 for guix-devel@gnu.org; Sat, 13 Feb 2016 17:23:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aUiaq-0004we-IM for guix-devel@gnu.org; Sat, 13 Feb 2016 17:23:11 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:33862) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUiap-0004wM-SO for guix-devel@gnu.org; Sat, 13 Feb 2016 17:23:08 -0500 Content-Disposition: inline In-Reply-To: <87ziv4tgzt.fsf@dustycloud.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Christopher Allan Webber Cc: guix-devel --qMm9M+Fa2AknHoGS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Feb 13, 2016 at 01:55:01PM -0800, Christopher Allan Webber wrote: > Christopher Allan Webber writes: [...] > >>> * gnu/packages/python.scm (python-wtforms, python2-wtforms): New variables. > >> > >> It looks good to me, but I wonder if the python-3 variant really needs > >> setuptools? If so, okay. If not, can you use the new python2-variant > >> system [0] to provide setuptools for python2-wtforms? > >> > >> [0] Introduced in 48b311b1b3ba > > > > Okay, I'll give that a try, and will make an adjustment if appropriate, > > and regardless, push after figuring that out. > > > > Thanks to both of you! > > Well, I think it's significant enough of a change where I should get > some validation that everything looks right before I push. New version, > ahoy! Is it ok? I believe that you still must call 'package-with-python2' in the python-2 variant, and the argument to that should be (strip-python2-variant python-foo). I've attached an example commit that seems to work, from one of my WIP branches. --qMm9M+Fa2AknHoGS Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-gnu-Add-python2-atomicwrites.patch" >From c5e63b1f8788e44657a5f508554dc8c21d00c3b4 Mon Sep 17 00:00:00 2001 From: Leo Famulari Date: Thu, 28 Jan 2016 00:42:33 -0500 Subject: [PATCH] gnu: Add python2-atomicwrites. * gnu/packages/python.scm (python2-atomicwrites): New variable. --- gnu/packages/python.scm | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm index 5b988c1..3f9886d 100644 --- a/gnu/packages/python.scm +++ b/gnu/packages/python.scm @@ -6751,7 +6751,14 @@ WebSocket usage in Python programs.") (description "Library for atomic file writes using platform dependent tools for atomic filesystem operations.") (home-page "https://github.com/untitaker/python-atomicwrites") - (license license:expat))) + (license license:expat) + (properties `((python2-variant . ,(delay python2-atomicwrites)))))) + +(define-public python2-atomicwrites + (package (inherit (package-with-python2 + (strip-python2-variant python-atomicwrites))) + (native-inputs + `(("python2-setuptools" ,python2-setuptools))))) (define-public python-requests-toolbelt (package -- 2.6.3 --qMm9M+Fa2AknHoGS--