From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Enge Subject: Re: [PATCH] gnu: Add slurm. Date: Sat, 13 Feb 2016 11:28:25 +0100 Message-ID: <20160213102825.GA19194@debian> References: <56bb7530.v5bvas2QpzoMjKMl%pjotr.public12@thebird.nl> <20160210220447.0917f1a1@openmailbox.org> <20160211081534.GA8987@thebird.nl> <20160212122042.GA14275@thebird.nl> <20160212123010.GA6019@debian.eduroam.u-bordeaux.fr> <20160212123141.GB14324@thebird.nl> <20160212125719.GA14615@thebird.nl> <20160213085940.GA18223@thebird.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48384) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUXRL-0007JR-2f for guix-devel@gnu.org; Sat, 13 Feb 2016 05:28:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aUXRH-0004JI-NG for guix-devel@gnu.org; Sat, 13 Feb 2016 05:28:34 -0500 Received: from mailrelay6.public.one.com ([91.198.169.200]:64678) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUXRH-0004JC-Ap for guix-devel@gnu.org; Sat, 13 Feb 2016 05:28:31 -0500 Content-Disposition: inline In-Reply-To: <20160213085940.GA18223@thebird.nl> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Pjotr Prins Cc: guix-devel@gnu.org On Sat, Feb 13, 2016 at 09:59:40AM +0100, Pjotr Prins wrote: > Another package name (this time we go down to slurm), another patch. Actually, the name of the patch file: slurm-wml-....patch should also be changed... And it needs to be registered in gnu-system.am. Some lines are way beyond 80 characters; this should be detected by "guix lint". > I also put the modules in alphabetic order when adding the license > name space. Hope that doesn't need a separate patch. I think that is fine. However, your patch still does not apply on top of master: Applying: gnu: Add slurm. .git/rebase-apply/patch:87: trailing whitespace. (substitute* "./doc/html/shtml2html.py" .git/rebase-apply/patch:119: space before tab in indent. config.xml .git/rebase-apply/patch:120: space before tab in indent. auxdir/Makefile .git/rebase-apply/patch:141: space before tab in indent. doc/Makefile .git/rebase-apply/patch:142: space before tab in indent. doc/man/Makefile error: patch failed: gnu/packages/parallel.scm:2 error: gnu/packages/parallel.scm: patch does not apply Patch failed at 0001 gnu: Add slurm. I do not think that the whitespace is a real issue; did you rebase before sending the patch? It is quite curious since the parallel.scm file has not been changed yet this year. Andreas