From: Andreas Enge <andreas@enge.fr>
To: Pjotr Prins <pjotr.public12@thebird.nl>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add slurm.
Date: Sat, 13 Feb 2016 11:28:25 +0100 [thread overview]
Message-ID: <20160213102825.GA19194@debian> (raw)
In-Reply-To: <20160213085940.GA18223@thebird.nl>
On Sat, Feb 13, 2016 at 09:59:40AM +0100, Pjotr Prins wrote:
> Another package name (this time we go down to slurm), another patch.
Actually, the name of the patch file: slurm-wml-....patch should also
be changed... And it needs to be registered in gnu-system.am.
Some lines are way beyond 80 characters; this should be detected by
"guix lint".
> I also put the modules in alphabetic order when adding the license
> name space. Hope that doesn't need a separate patch.
I think that is fine.
However, your patch still does not apply on top of master:
Applying: gnu: Add slurm.
.git/rebase-apply/patch:87: trailing whitespace.
(substitute* "./doc/html/shtml2html.py"
.git/rebase-apply/patch:119: space before tab in indent.
config.xml
.git/rebase-apply/patch:120: space before tab in indent.
auxdir/Makefile
.git/rebase-apply/patch:141: space before tab in indent.
doc/Makefile
.git/rebase-apply/patch:142: space before tab in indent.
doc/man/Makefile
error: patch failed: gnu/packages/parallel.scm:2
error: gnu/packages/parallel.scm: patch does not apply
Patch failed at 0001 gnu: Add slurm.
I do not think that the whitespace is a real issue; did you rebase before
sending the patch? It is quite curious since the parallel.scm file has not
been changed yet this year.
Andreas
next prev parent reply other threads:[~2016-02-13 10:28 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 17:36 [PATCH] gnu: Add slurm-llnl Pjotr Prins
2016-02-11 4:04 ` Eric Bavier
2016-02-11 8:15 ` Pjotr Prins
2016-02-11 10:08 ` Andreas Enge
2016-02-11 11:11 ` Pjotr Prins
2016-02-11 14:21 ` Andreas Enge
2016-02-11 15:00 ` Pjotr Prins
2016-02-12 12:30 ` Pjotr Prins
2016-02-11 15:19 ` Eric Bavier
2016-02-12 12:20 ` Pjotr Prins
2016-02-12 12:30 ` Andreas Enge
2016-02-12 12:31 ` Pjotr Prins
2016-02-12 12:57 ` [PATCH] gnu: Add slurm-wlm Pjotr Prins
2016-02-12 17:51 ` Andreas Enge
2016-02-13 8:59 ` [PATCH] gnu: Add slurm Pjotr Prins
2016-02-13 10:28 ` Andreas Enge [this message]
2016-02-13 16:42 ` Pjotr Prins
2016-02-13 17:00 ` Andreas Enge
2016-02-13 17:01 ` Pjotr Prins
2016-02-13 17:20 ` Andreas Enge
2016-02-13 20:13 ` Leo Famulari
2016-02-13 20:34 ` Andreas Enge
2016-02-13 20:40 ` Leo Famulari
2016-02-14 14:22 ` Andreas Enge
2016-02-14 19:08 ` Leo Famulari
2016-02-15 12:09 ` Pjotr Prins
2016-02-15 21:51 ` Andreas Enge
2016-02-16 7:21 ` Pjotr Prins
2016-02-16 9:55 ` Andreas Enge
2016-02-13 20:38 ` Leo Famulari
2016-02-13 21:32 ` Pjotr Prins
2016-02-13 21:43 ` Leo Famulari
2016-02-13 17:13 ` Pjotr Prins
2016-02-11 4:33 ` [PATCH] gnu: Add slurm-llnl Eric Bavier
2016-02-11 8:17 ` Pjotr Prins
2016-02-11 8:28 ` Ricardo Wurmus
2016-02-11 18:36 ` Efraim Flashner
-- strict thread matches above, loose matches on Subject: below --
2016-02-13 17:22 [PATCH] gnu: Add slurm Pjotr Prins
2016-02-13 17:30 ` Andreas Enge
2016-02-13 17:21 Pjotr Prins
2016-02-13 17:21 Pjotr Prins
2016-02-13 17:18 Pjotr Prins
2016-02-13 17:14 Pjotr Prins
2015-12-28 22:00 swedebugia
2015-12-28 23:13 ` Eric Bavier
2015-12-29 4:31 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160213102825.GA19194@debian \
--to=andreas@enge.fr \
--cc=guix-devel@gnu.org \
--cc=pjotr.public12@thebird.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).