From: Andreas Enge <andreas@enge.fr>
To: Jan Nieuwenhuizen <janneke@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add laby.
Date: Sat, 13 Feb 2016 09:43:29 +0100 [thread overview]
Message-ID: <20160213084329.GA10278@debian> (raw)
In-Reply-To: <87pow19gii.fsf@gnu.org>
On Sat, Feb 13, 2016 at 09:11:17AM +0100, Jan Nieuwenhuizen wrote:
> Nice! New patch set attached.
Very good, I pushed the first two. Concerning the commit message, it should
read "gnu: ocaml: ..." in case a package is modified.
> Subject: [PATCH 3/3] gnu: Add laby.
> * gnu/packages/patches/laby-make-install.patch: New file.
> * gnu/packages/patches/laby-make-png.patch: New file.
> * gnu-system.am (dist_patch_DATA): Add them.
> * gnu/packages/games.scm (laby): New variable.
Here I would not use a patch. The policy is not totally clear (and not
written up), but if an additional phase for installation is needed, I
would do it in a custom phase on the scheme side instead of patching the
makefile. See, for instance, the tinyxml package in xml.scm.
Maybe it would also warrant an upstream bug report?
Similarly for the make-png patch. Is this an upstream bug?
Andreas
PS: The game starts and shows the maze, it looks quite nice!
PPS: You do not happen to use unison? I think your previous patches would
allow to build it with gtk support, and unlike me, you seem to know
what you are doing...
next prev parent reply other threads:[~2016-02-13 8:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 20:27 [PATCH] gnu: Add laby Jan Nieuwenhuizen
2016-02-09 22:28 ` Christopher Allan Webber
2016-02-11 20:18 ` Efraim Flashner
2016-02-11 22:21 ` Jan Nieuwenhuizen
2016-02-12 18:09 ` Andreas Enge
2016-02-13 8:11 ` Jan Nieuwenhuizen
2016-02-13 8:43 ` Andreas Enge [this message]
2016-02-13 14:09 ` Jan Nieuwenhuizen
2016-02-13 14:16 ` Andreas Enge
2016-02-13 20:58 ` Jan Nieuwenhuizen
2016-03-06 19:27 ` Andreas Enge
2016-03-06 22:01 ` Jan Nieuwenhuizen
2016-08-10 15:10 ` Jan Nieuwenhuizen
2016-08-11 11:50 ` 宋文武
2016-02-12 18:13 ` Andreas Enge
2016-02-12 20:43 ` Jan Nieuwenhuizen
2016-02-13 8:20 ` Andreas Enge
2016-02-13 13:08 ` Jan Nieuwenhuizen
2016-02-12 18:17 ` Andreas Enge
2016-02-12 18:30 ` Jan Nieuwenhuizen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160213084329.GA10278@debian \
--to=andreas@enge.fr \
--cc=guix-devel@gnu.org \
--cc=janneke@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).