From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] gnu: Add spice-protocol. Date: Fri, 12 Feb 2016 19:31:05 -0500 Message-ID: <20160213003105.GA13163@jasmine> References: <12541d95db51a675a0adc0d43464784e@openmailbox.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35868) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUO77-0002Mq-V2 for guix-devel@gnu.org; Fri, 12 Feb 2016 19:31:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aUO73-0003cU-Dd for guix-devel@gnu.org; Fri, 12 Feb 2016 19:31:05 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:45520) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUO73-0003cL-A4 for guix-devel@gnu.org; Fri, 12 Feb 2016 19:31:01 -0500 Content-Disposition: inline In-Reply-To: <12541d95db51a675a0adc0d43464784e@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: rennes@openmailbox.org Cc: guix-devel@gnu.org On Thu, Feb 11, 2016 at 07:56:56AM -0600, rennes@openmailbox.org wrote: > Hi, > > i attached spice-protocol patch for review. Thanks for the patch! > > SPICE protocol, is a required package to package spice-gtk(requiered for > GNOME Vinagre). > > Considerations: > > a) I use the source: "http://www.spice-space.org/download/releases/" instead > "https://cgit.freedesktop.org/spice/spice-protocol". > b) The home page "http://www.spice-space.org" instead > "https://cgit.freedesktop.org/spice/spice-protocol". Okay. > * gnu/packages/gnome.scm (spice-protocol): New variable. The patch looks good. I don't know how to test whether or not the software it installs _works_ or not. Have you tested that?