From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Enge Subject: Re: [PATCH] gnu: Add laby. Date: Fri, 12 Feb 2016 19:09:05 +0100 Message-ID: <20160212180905.GA8954@debian> References: <87egcleiig.fsf@gnu.org> <87fux1y0vg.fsf@dustycloud.org> <20160211221839.73cf23b5@debian-netbook> <87k2madh1x.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60313) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUI9c-0000xY-IV for guix-devel@gnu.org; Fri, 12 Feb 2016 13:09:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aUI9Z-0002x3-3T for guix-devel@gnu.org; Fri, 12 Feb 2016 13:09:15 -0500 Received: from mailrelay6.public.one.com ([91.198.169.200]:12582) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUI9Y-0002vu-Mu for guix-devel@gnu.org; Fri, 12 Feb 2016 13:09:13 -0500 Content-Disposition: inline In-Reply-To: <87k2madh1x.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Jan Nieuwenhuizen Cc: guix-devel@gnu.org Hello, On Thu, Feb 11, 2016 at 11:21:30PM +0100, Jan Nieuwenhuizen wrote: > Ah... And also, ocaml-findlib was missing and lablgtk did not compile > cmxa files, which laby needs. So, three patches to get a running Laby. > + (native-search-paths > + (list (search-path-specification > + (variable "OCAMLPATH") > + (files (list (string-append "lib/ocaml")))))) I have doubts about this search path. Normally, a search path is registered with the program that needs it; for instance, gcc declares a LIBRARY_PATH, and then whenever a program is installed that provides libraries, these are added to the environment variable. So I suppose the search path declaration should really be in the ocaml package, and if lablgtk provides files matching the pattern, they will be added and available for laby. What do you think? If yes, this should be split into two patches. (There are still minor things, like a missing copyright line, indentation and so on; if you modify your patches anyway, you might widh to have a second look.) Andreas