unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Andreas Enge <andreas@enge.fr>
To: Jan Nieuwenhuizen <janneke@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add laby.
Date: Fri, 12 Feb 2016 19:09:05 +0100	[thread overview]
Message-ID: <20160212180905.GA8954@debian> (raw)
In-Reply-To: <87k2madh1x.fsf@gnu.org>

Hello,

On Thu, Feb 11, 2016 at 11:21:30PM +0100, Jan Nieuwenhuizen wrote:
> Ah... And also, ocaml-findlib was missing and lablgtk did not compile
> cmxa files, which laby needs.  So, three patches to get a running Laby.

> +   (native-search-paths
> +    (list (search-path-specification
> +           (variable "OCAMLPATH")
> +           (files (list (string-append "lib/ocaml"))))))

I have doubts about this search path. Normally, a search path is registered
with the program that needs it; for instance, gcc declares a LIBRARY_PATH,
and then whenever a program is installed that provides libraries, these are
added to the environment variable.

So I suppose the search path declaration should really be in the ocaml
package, and if lablgtk provides files matching the pattern, they will be
added and available for laby.

What do you think? If yes, this should be split into two patches.

(There are still minor things, like a missing copyright line, indentation
and so on; if you modify your patches anyway, you might widh to have a
second look.)

Andreas

  reply	other threads:[~2016-02-12 18:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-09 20:27 [PATCH] gnu: Add laby Jan Nieuwenhuizen
2016-02-09 22:28 ` Christopher Allan Webber
2016-02-11 20:18   ` Efraim Flashner
2016-02-11 22:21     ` Jan Nieuwenhuizen
2016-02-12 18:09       ` Andreas Enge [this message]
2016-02-13  8:11         ` Jan Nieuwenhuizen
2016-02-13  8:43           ` Andreas Enge
2016-02-13 14:09             ` Jan Nieuwenhuizen
2016-02-13 14:16               ` Andreas Enge
2016-02-13 20:58                 ` Jan Nieuwenhuizen
2016-03-06 19:27                   ` Andreas Enge
2016-03-06 22:01                     ` Jan Nieuwenhuizen
2016-08-10 15:10                       ` Jan Nieuwenhuizen
2016-08-11 11:50                         ` 宋文武
2016-02-12 18:13       ` Andreas Enge
2016-02-12 20:43         ` Jan Nieuwenhuizen
2016-02-13  8:20           ` Andreas Enge
2016-02-13 13:08             ` Jan Nieuwenhuizen
2016-02-12 18:17       ` Andreas Enge
2016-02-12 18:30         ` Jan Nieuwenhuizen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160212180905.GA8954@debian \
    --to=andreas@enge.fr \
    --cc=guix-devel@gnu.org \
    --cc=janneke@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).