unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: Christopher Allan Webber <cwebber@dustycloud.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add laby.
Date: Thu, 11 Feb 2016 22:18:39 +0200	[thread overview]
Message-ID: <20160211221839.73cf23b5@debian-netbook> (raw)
In-Reply-To: <87fux1y0vg.fsf@dustycloud.org>

[-- Attachment #1: Type: text/plain, Size: 1055 bytes --]

On Tue, 09 Feb 2016 14:28:35 -0800
Christopher Allan Webber <cwebber@dustycloud.org> wrote:

> Jan Nieuwenhuizen writes:
> 
>  [...]  
> 
> Now this looks like a lot of fun!
> 
> Some of these lines are over 80 characters though.. could you fix that?
> 
> I tried running this though and the patch it provided didn't seem to
> apply.

The patch isn't registered in gnu-system.am, so that should be why.

>  I also see it's doing manual cp to /usr/games/laby and
> etc... but could that really work?  Shouldn't it be copying to the
> output directory in the store instead?
> 
> Maybe adding your own install step to the build phases would be nicest
> here?
> 
> Anyway, would love to see this packaged, and play with it myself!
> 

That's all I have to add, other than I'm also looking forward to playing the
game.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2016-02-11 20:18 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-09 20:27 [PATCH] gnu: Add laby Jan Nieuwenhuizen
2016-02-09 22:28 ` Christopher Allan Webber
2016-02-11 20:18   ` Efraim Flashner [this message]
2016-02-11 22:21     ` Jan Nieuwenhuizen
2016-02-12 18:09       ` Andreas Enge
2016-02-13  8:11         ` Jan Nieuwenhuizen
2016-02-13  8:43           ` Andreas Enge
2016-02-13 14:09             ` Jan Nieuwenhuizen
2016-02-13 14:16               ` Andreas Enge
2016-02-13 20:58                 ` Jan Nieuwenhuizen
2016-03-06 19:27                   ` Andreas Enge
2016-03-06 22:01                     ` Jan Nieuwenhuizen
2016-08-10 15:10                       ` Jan Nieuwenhuizen
2016-08-11 11:50                         ` 宋文武
2016-02-12 18:13       ` Andreas Enge
2016-02-12 20:43         ` Jan Nieuwenhuizen
2016-02-13  8:20           ` Andreas Enge
2016-02-13 13:08             ` Jan Nieuwenhuizen
2016-02-12 18:17       ` Andreas Enge
2016-02-12 18:30         ` Jan Nieuwenhuizen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160211221839.73cf23b5@debian-netbook \
    --to=efraim@flashner.co.il \
    --cc=cwebber@dustycloud.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).