Re: [PATCH 2/5] gnu: Add mate-themes.

[Fabian Harfert <fhmgufs@web.de>]

Am Thu, 11 Feb 2016 22:51:44 +0200
schrieb Efraim Flashner <efraim@flashner.co.il>:

> On Wed, 10 Feb 2016 00:00:21 +0100
> Fabian Harfert <fhmgufs@web.de> wrote:
> 
> > From: Fabian Harfert <fhmgufs@web.de>
> > To: guix-devel@gnu.org
> > Subject: [PATCH 2/5] gnu: Add mate-themes.
> > Date: Wed, 10 Feb 2016 00:00:21 +0100
> > Sender: guix-devel-bounces+efraim=flashner.co.il@gnu.org
> > X-Mailer: git-send-email 2.7.0
> > 
> > * gnu/packages/mate.scm (mate-themes): New variable.
> > ---
> >  gnu/packages/mate.scm | 32 ++++++++++++++++++++++++++++++++
> >  1 file changed, 32 insertions(+)
> > 
> > diff --git a/gnu/packages/mate.scm b/gnu/packages/mate.scm
> > index d8242d6..6e5ce7c 100644
> > --- a/gnu/packages/mate.scm
> > +++ b/gnu/packages/mate.scm
> > @@ -51,3 +51,35 @@
> >      (description
> >       "This package contains the default icon theme used by the
> > MATE desktop.") (license license:lgpl3+)))
> > +
> > +(define-public mate-themes
> > +  (package
> > +    (name "mate-themes")
> > +    (version "1.12.2")
> > +    (source (origin
> > +              (method url-fetch)
> > +              (uri (string-append
> > "http://pub.mate-desktop.org/releases/"
> > +                                  (version-major+minor version) "/"
> > +                                  name "-gtk"
> > +                                  (version-major+minor
> > (package-version gtk+))
> > +                                  "-" version ".tar.xz"))  
> I applied the first two patches to my checkout and although I was
> sure it would try to use the gtk+-2 from the inputs, it downloaded
> mate-themes-gtk3.18-1.12.2.tar.xz

That's right. Of course the themes should support the newest Gtk+
versions. I'm not sure wether gtk+-2 is really needed as an input, but
the developers mention it in their Debian and Arch packages. Because
they didn't include gtk+-3 I thought that it might be needed.

> 
> > +              (sha256
> > +               (base32
> > +
> > "0kyrlgs5azzj60gnxx2n9qszcligxn959wr42wr0iqnrpiygk5nf"))))
> > +    (build-system gnu-build-system)
> > +    (native-inputs
> > +     `(("pkg-config" ,pkg-config)
> > +       ("intltool" ,intltool)))
> > +    (inputs
> > +     `(("gtk+" ,gtk+-2)
> > +       ("gdk-pixbuf" ,gdk-pixbuf)
> > +       ("gtk-engines" ,gtk-engines)
> > +       ("murrine" ,murrine)))
> > +    (home-page "http://mate-desktop.org/")
> > +    (synopsis
> > +     "Official themes for the MATE desktop")
> > +    (description
> > +     "This package includes the standard themes for the MATE
> > desktop, for +example Menta, TraditionalOk, GreenLaguna or
> > BlackMate.")
> > +    (license (list license:lgpl2.1+ license:cc-by-sa3.0
> > license:gpl3+
> > +                   license:gpl2+))))  
> Any chance the 4 themes match up with the 4 licenses?
> 
> It looks good to me
> 
>