From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: [PATCH] gnu: Add tcllib. Date: Thu, 11 Feb 2016 21:53:47 +0200 Message-ID: <20160211215347.0aac83dd@debian-netbook> References: <87vb5xeiw8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/3ePCH2aQNrgnp62c7uIJhd="; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54647) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTxJQ-00075i-VZ for guix-devel@gnu.org; Thu, 11 Feb 2016 14:54:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTxJM-00069B-Mm for guix-devel@gnu.org; Thu, 11 Feb 2016 14:54:00 -0500 In-Reply-To: <87vb5xeiw8.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Jan Nieuwenhuizen Cc: guix-devel@gnu.org --Sig_/3ePCH2aQNrgnp62c7uIJhd= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, 09 Feb 2016 21:19:35 +0100 Jan Nieuwenhuizen wrote: > From: Jan Nieuwenhuizen > To: guix-devel@gnu.org > Subject: [PATCH] gnu: Add tcllib. > Date: Tue, 09 Feb 2016 21:19:35 +0100 > Sender: guix-devel-bounces+efraim=3Dflashner.co.il@gnu.org > User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) > Organization: AvatarAcademy.nl >=20 > Hi, >=20 > A "new" package. >=20 > Greetings, Jan >=20 >=20 > From 51f0b17b38385197240bca37b290730b2fbe5df1 Mon Sep 17 00:00:00 2001 > From: Jan Nieuwenhuizen > Date: Tue, 9 Feb 2016 20:44:59 +0100 > Subject: [PATCH] gnu: Add tcllib. >=20 > * gnu/packages/tcl.scm (tcllib): New variable. > --- > gnu/packages/tcl.scm | 31 +++++++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) >=20 > diff --git a/gnu/packages/tcl.scm b/gnu/packages/tcl.scm > index 2c4c750..8d6059d 100644 > --- a/gnu/packages/tcl.scm > +++ b/gnu/packages/tcl.scm > @@ -3,6 +3,7 @@ > ;;; Copyright =C2=A9 2014, 2015 Mark H Weaver > ;;; Copyright =C2=A9 2014 Eric Bavier > ;;; Copyright =C2=A9 2016 Efraim Flashner > +;;; Copyright =C2=A9 2016 Jan Nieuwenhuizen > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -219,3 +220,33 @@ interfaces (GUIs) in the Tcl language.") > ;; pTk/license.terms, pTk/license.html_lib, and pTk/Tix.license for > ;; details of this license." > (license (package-license perl)))) > + > +(define-public tcllib > + (package > + (name "tcllib") > + (version "1.18") > + (source (origin > + (method url-fetch) > + (uri (string-append "mirror://sourceforge/" name "/" > + name "-" version ".tar.gz")) > + (sha256 > + (base32 > + "05dmrk9qsryah2n17z6z85dj9l9lfyvnsd7faw0p9bs1pp5pwrkj"))= )) > + (build-system gnu-build-system) > + (native-inputs > + `(("tcl" ,tcl))) > + (native-search-paths > + (list (search-path-specification I don't think this needs to be a list. Also, it should be indented 2 spaces (I believe) > + (variable "TCLLIBPATH") > + (separator " ") > + (files (list (string-append "lib/tcllib" version "")))))) why the double quote after version? > + (home-page "https://core.tcl.tk/tcllib/home") > + (synopsis "Standard Tcl Library") > + (description "Tcllib, the standard Tcl library, is a collection of c= ommon utility utility should be on the next line > + functions and modules all written in high-level Tcl. > +") the ") should be on the previous line > + (license (non-copyleft "http://www.tcl.tk/software/tcltk/license.htm= l" > + "Tcl/Tk license")))) I can't find it on the FSF list (https://www.gnu.org/licenses/license-list.= html),=20 but according to https://fedoraproject.org/wiki/Licensing:Main?rd=3DLicensi= ng, the Tcl license is a FSF approved license, so another patch before this one to add it to the license list would be good. It's possible that I'm wrong, = so if someone else can check me that'd be good. > + > + > + you don't need all these extra spaces --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --Sig_/3ePCH2aQNrgnp62c7uIJhd= Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJWvObLAAoJEPTB05F+rO6TGgkQAI1tqepkATw5LTLQjNPHESly R09wI8Z8MByFqLyi3R2FhntHclSKOtDoYlEmV1EZCdxM3lU7JqS5ptwcZkt1D5AE d4uw/twrpi4qbqwbjX5KUNzd8Sr8nPL5KAxJ7T7L3Alm0VBaGzmZxqoiFKSeA0G8 WgF2DuvfEqYWcYaQ2SMtUdc0I3+1n4UENCUqPJuAMks+5m4z6tNzrlF8HNaawvaT /hs3J8pe5q6l8d/rqvCKmQOenGxEWWxHfOZQWDhjRaJ0KcNwPAeGZ0vlqWrHLihm i1gX4rZKBmX621rUb1+ErpWNZ01dglH/zr71VPZPmF/fbjDhqoZNbCbAcjMOPF8t tHsqnn0cI5x1lCrihR/6icbQQUNcF6ecuZEhMvC3RHgSQxJkeZhbPsqmUXhKJslb fd0BxI+VdO0bhIkq+rTIwmU9O1ZFgJP0Dlxjrpbp7q+V9Kk569dN6mPnGxw19xag hiI3HmwYvbCM75RDgtGMW74D0++Rl8Ey55hIJ6PS1VNspbCL8HOOVh4OWAhKUOwi GqdxBOyRQ0spi0MvyzVzoJGu7nbkRsXXEb6vxpxX7PhNFZQmjwK2Z+1vumq0Ycyf yUDigLDeQkwrVLZkybLPdQKZNu779h2y/iI8dW4qv4J1QU9Y350YZbTQCPbRHA2Y UkczilMansxDosApX+QB =fKHL -----END PGP SIGNATURE----- --Sig_/3ePCH2aQNrgnp62c7uIJhd=--