[PATCH] gnu: python-sqlalchemy: Update to 1.0.11 (oops: fixed name).

[PATCH] gnu: python-sqlalchemy: Update to 1.0.11 (oops: fixed name).

[Pjotr Prins]

* gnu/packages/python.scm (python-sqlalchemy):
Update to 1.0.11
---
 gnu/packages/python.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 5b988c1..47c7975 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -3549,7 +3549,7 @@ routines such as routines for numerical integration and optimization.")
 (define-public python-sqlalchemy
   (package
     (name "python-sqlalchemy")
-    (version "0.9.7")
+    (version "1.0.11")
     (source
      (origin
       (method url-fetch)
@@ -3557,7 +3557,7 @@ routines such as routines for numerical integration and optimization.")
                           "SQLAlchemy/SQLAlchemy-" version ".tar.gz"))
       (sha256
        (base32
-        "059ayifj5l08v6vv56anhyibyllscn10dlzr2fcw68gz1hfjdzsz"))))
+        "18z81m3ypcgqmsqn61qpfm75b98z5fihx23hjw05a57shybp490b"))))
     (build-system python-build-system)
     (native-inputs
      `(("python-cython" ,python-cython) ;for c extensions
-- 
2.1.4

Re: [PATCH] gnu: python-sqlalchemy: Update to 1.0.11 (oops: fixed name).

[Christopher Allan Webber]

Pjotr Prins writes:

> * gnu/packages/python.scm (python-sqlalchemy):
> Update to 1.0.11
> ---
>  gnu/packages/python.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 5b988c1..47c7975 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -3549,7 +3549,7 @@ routines such as routines for numerical integration and optimization.")
>  (define-public python-sqlalchemy
>    (package
>      (name "python-sqlalchemy")
> -    (version "0.9.7")
> +    (version "1.0.11")
>      (source
>       (origin
>        (method url-fetch)
> @@ -3557,7 +3557,7 @@ routines such as routines for numerical integration and optimization.")
>                            "SQLAlchemy/SQLAlchemy-" version ".tar.gz"))
>        (sha256
>         (base32
> -        "059ayifj5l08v6vv56anhyibyllscn10dlzr2fcw68gz1hfjdzsz"))))
> +        "18z81m3ypcgqmsqn61qpfm75b98z5fihx23hjw05a57shybp490b"))))
>      (build-system python-build-system)
>      (native-inputs
>       `(("python-cython" ,python-cython) ;for c extensions

LGTM, push it!

. o O (iirc, version bump pushes are often ok to just push to guix)
      (master if you have commit access without review, right?)

 - Chris

Re: [PATCH] gnu: python-sqlalchemy: Update to 1.0.11 (oops: fixed name).

[Leo Famulari]

On Mon, Feb 08, 2016 at 09:26:42AM -0800, Christopher Allan Webber wrote:
> Pjotr Prins writes:
> 
> > * gnu/packages/python.scm (python-sqlalchemy):
> > Update to 1.0.11

[...]

> LGTM, push it!
> 
> . o O (iirc, version bump pushes are often ok to just push to guix)
>       (master if you have commit access without review, right?)

I'd say they're fine to push if they are a leaf package or a seldom used
library. On the other hand, if many things depend on them, it's best to
ask, or push to a staging branch if you already know that's the answer.

> 
>  - Chris
> 

Re: [PATCH] gnu: python-sqlalchemy: Update to 1.0.11 (oops: fixed name).

[Andreas Enge]

Hello,

I applied the patch and got a test failure:

sqlalchemy.exc.NoSuchColumnError: "Could not locate column in row for column 'users.user_id'"
=========================== short test summary info ============================
FAIL test/sql/test_resultset.py::ResultProxyTest_sqlite_pysqlite::()::test_column_accessor_sqlite_raw
FAIL test/sql/test_resultset.py::ResultProxyTest_sqlite_pysqlite::()::test_column_accessor_sqlite_translated
============= 2 failed, 6531 passed, 785 skipped in 194.43 seconds =============
phase `check' failed after 200.1 seconds

The same for the Python 2 version.

Andreas

Re: [PATCH] gnu: python-sqlalchemy: Update to 1.0.11 (oops: fixed name).

[Andreas Enge]

Sorry, I did not realise that this is related to the sqlite thing.
Maybe file a bug report upstream?

Andreas

Re: [PATCH] gnu: python-sqlalchemy: Update to 1.0.11 (oops: fixed name).

[Pjotr Prins]

On Mon, Feb 08, 2016 at 09:07:46PM +0100, Andreas Enge wrote:
> Sorry, I did not realise that this is related to the sqlite thing.

Yes, it is not about this version of python-sqlalchemy.

> Maybe file a bug report upstream?

They will fix it when they upgrade sqlite. python-sqlalchemy is under
active development. Question is what we do for the time being with
sqlite. 

Pj.

-- 

Re: [PATCH] gnu: python-sqlalchemy: Update to 1.0.11 (oops: fixed name).

[Andreas Enge]

On Mon, Feb 08, 2016 at 09:49:51PM +0100, Pjotr Prins wrote:
> They will fix it when they upgrade sqlite. python-sqlalchemy is under
> active development. Question is what we do for the time being with
> sqlite. 

I would say the culprit is python-sqlalchemy and not sqlite. So if you
cannot wait for upstream to fix their package, one possibility would be
to add a package for on older version of sqlite (assuming it does not
present security problems) and to build python-sqlalchemy with it.
It could even be a private variable only used in this input instead of
a user visible variant.

Andreas

Re: [PATCH] gnu: python-sqlalchemy: Update to 1.0.11 (oops: fixed name).

[Pjotr Prins]

Yes, that is what I have already done. I can't afford to wait ;)

I am just wondering how many packages are broken (visibly or not).

Sqlite changed something fundamental.

Pj.

On Mon, Feb 08, 2016 at 09:57:10PM +0100, Andreas Enge wrote:
> On Mon, Feb 08, 2016 at 09:49:51PM +0100, Pjotr Prins wrote:
> > They will fix it when they upgrade sqlite. python-sqlalchemy is under
> > active development. Question is what we do for the time being with
> > sqlite. 
> 
> I would say the culprit is python-sqlalchemy and not sqlite. So if you
> cannot wait for upstream to fix their package, one possibility would be
> to add a package for on older version of sqlite (assuming it does not
> present security problems) and to build python-sqlalchemy with it.
> It could even be a private variable only used in this input instead of
> a user visible variant.
> 
> Andreas
> 

-- 

Re: [PATCH] gnu: python-sqlalchemy: Update to 1.0.11 (oops: fixed name).

[Christopher Allan Webber]

Leo Famulari writes:

> On Mon, Feb 08, 2016 at 09:26:42AM -0800, Christopher Allan Webber wrote:
>> Pjotr Prins writes:
>> 
>> > * gnu/packages/python.scm (python-sqlalchemy):
>> > Update to 1.0.11
>
> [...]
>
>> LGTM, push it!
>> 
>> . o O (iirc, version bump pushes are often ok to just push to guix)
>>       (master if you have commit access without review, right?)
>
> I'd say they're fine to push if they are a leaf package or a seldom used
> library. On the other hand, if many things depend on them, it's best to
> ask, or push to a staging branch if you already know that's the answer.

Thanks for the clarity!

Re: [PATCH] gnu: python-sqlalchemy: Update to 1.0.11 (oops: fixed name).

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 584 bytes --]

On Mon, 8 Feb 2016 22:09:25 +0100
Pjotr Prins <pjotr.public12@thebird.nl> wrote:

> Yes, that is what I have already done. I can't afford to wait ;)
> 
> I am just wondering how many packages are broken (visibly or not).
> 
> Sqlite changed something fundamental.
> 
> Pj.
> 

I locally updated sqlite to 3.10.2 and that didn't help with
python-sqlalchemy.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]