From: Leo Famulari <leo@famulari.name>
To: Andreas Enge <andreas@enge.fr>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: gdk-pixbuf: Disable pixbuf-scale test.
Date: Sun, 7 Feb 2016 16:17:39 -0500 [thread overview]
Message-ID: <20160207211739.GB21689@jasmine> (raw)
In-Reply-To: <20160207111537.GB5011@debian>
On Sun, Feb 07, 2016 at 12:15:37PM +0100, Andreas Enge wrote:
> On Sat, Feb 06, 2016 at 03:56:24PM -0500, Leo Famulari wrote:
> > I would like another option besides disabling the test unconditionally.
> > We already have several packages that can simply not be built on
> > hardware like Jookia's, and although it's an unfortunate situation, I
> > don't think we should start disabling tests for the substitutes we build
> > for this reason. Running all the tests possible allows us to provide
> > valuable feedback to upstream.
>
> I basically agree with your comment, which is also in line with our policy
> of following upstream as closely as possible when building packages.
> On the other hand, a simple unit test that requires 2GB of memory seems a bit
> excessive to me and could be considered a bug in the upstream package.
> How about reporting a bug upstream, Jookia? And maybe disable the test
> in the package with a comment linking to the bug report?
True, depending on the nature of the software it could be considered a
bug. There are some programs, like compression algorithm
implementations, where I think such tests can be appropriate, however.
>
> Andreas
>
next prev parent reply other threads:[~2016-02-07 21:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 21:25 [PATCH] gnu: gdk-pixbuf: Disable pixbuf-scale test Jookia
2016-02-06 15:17 ` Andreas Enge
2016-02-06 20:56 ` Leo Famulari
2016-02-07 11:15 ` Andreas Enge
2016-02-07 11:27 ` Jookia
2016-02-07 21:17 ` Leo Famulari [this message]
2016-02-06 21:04 ` Jookia
2016-02-06 22:24 ` Leo Famulari
2016-02-07 20:06 ` Ludovic Courtès
2016-02-07 21:59 ` Jookia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160207211739.GB21689@jasmine \
--to=leo@famulari.name \
--cc=andreas@enge.fr \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).