From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Enge Subject: Re: [PATCH] gnu: Add libcanberra-gtk2. Date: Sun, 7 Feb 2016 15:03:39 +0100 Message-ID: <20160207140339.GA17080@debian> References: <20160207111308.GA5011@debian> <1454852485-11533-1-git-send-email-fhmgufs@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55557) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSPwL-0007hL-3Z for guix-devel@gnu.org; Sun, 07 Feb 2016 09:03:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSPwG-0001u2-4j for guix-devel@gnu.org; Sun, 07 Feb 2016 09:03:49 -0500 Received: from mailrelay7.public.one.com ([91.198.169.215]:58703) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSPwF-0001ty-PX for guix-devel@gnu.org; Sun, 07 Feb 2016 09:03:44 -0500 Content-Disposition: inline In-Reply-To: <1454852485-11533-1-git-send-email-fhmgufs@web.de> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Fabian Harfert Cc: guix-devel@gnu.org Hello, this looks good to me. However, the package now cannot be installed together with the "normal" libcanberra package, as both contain lib/libcanberra.so.0.2.5. I suppose that is okay? Would you mind sending a patch formatted with "git format-patch", after committing to a local branch with the usual commit message? Then your authorship will be preserved to posterity; otherwise I would look like the author when I push. And I suppose there will be more patches from you, so it is probably worth the effort to get used to this workflow! Thanks, Andreas