From: Andreas Enge <andreas@enge.fr>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>, 22437@debbugs.gnu.org
Subject: Re: bug#22437: Fixing package-with-python2
Date: Sun, 7 Feb 2016 12:09:29 +0100 [thread overview]
Message-ID: <20160207110929.GA4968@debian> (raw)
In-Reply-To: <87twlqxjsc.fsf@gnu.org>
Hello,
this looks really good, but I do not understand why we need the
additional private variable, for instance %python-cython:
On Wed, Feb 03, 2016 at 09:47:15AM +0100, Ludovic Courtès wrote:
> -(define-public python-cython
> +(define %python-cython
> (package
> (name "python-cython")
> (version "0.23.4")
> @@ -2946,8 +2946,13 @@ programming language and the extended Cython programming language. It makes
> writing C extensions for Python as easy as Python itself.")
> (license asl2.0)))
>
> +(define-public python-cython
> + (package
> + (inherit %python-cython)
> + (properties `((python2-variant . ,(delay python2-cython))))))
> +
> (define-public python2-cython
> - (package (inherit (package-with-python2 python-cython))
> + (package (inherit (package-with-python2 %python-cython))
> (name "python2-cython")
> (inputs
If python2-cython inherits from (package-with-python2 python-cython),
is not the only difference that it keeps the properties field? And
would this not be harmless, as we are not going to call package-with-python2
again? Or would this create a circular dependency with (delay python2-cython)?
(In C or Pascal, this would not be a problem, one could simply declare
things before they are used, and that is it.)
It would be more elegant to drop the additional variable if possible.
Andreas
next prev parent reply other threads:[~2016-02-07 11:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 13:49 Fixing package-with-python2 (was: Package transformations) Thompson, David
2016-02-01 14:26 ` Pjotr Prins
2016-02-01 16:35 ` Efraim Flashner
2016-02-01 16:49 ` Thompson, David
2016-02-01 17:12 ` Andreas Enge
2016-02-01 22:11 ` Fixing package-with-python2 Ludovic Courtès
2016-02-01 22:07 ` Ludovic Courtès
2016-02-01 22:12 ` Thompson, David
2016-02-02 7:50 ` Efraim Flashner
2016-02-03 8:47 ` Ludovic Courtès
2016-02-07 8:17 ` bug#22437: " Efraim Flashner
2016-02-07 9:32 ` Ricardo Wurmus
2016-02-07 20:35 ` Ludovic Courtès
2016-02-07 20:42 ` Ludovic Courtès
2016-02-08 15:11 ` Ludovic Courtès
2016-02-07 11:09 ` Andreas Enge [this message]
2016-02-07 20:39 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160207110929.GA4968@debian \
--to=andreas@enge.fr \
--cc=22437@debbugs.gnu.org \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).