unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Andreas Enge <andreas@enge.fr>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: gdk-pixbuf: Disable pixbuf-scale test.
Date: Sat, 6 Feb 2016 15:56:24 -0500	[thread overview]
Message-ID: <20160206205624.GB6348@jasmine> (raw)
In-Reply-To: <20160206151749.GA9236@debian>

On Sat, Feb 06, 2016 at 04:17:49PM +0100, Andreas Enge wrote:
> On Tue, Feb 02, 2016 at 09:25:41PM +0000, Jookia wrote:
> > On systems with little ram (2G in my case) the pixbuf-scale test will either
> > freeze the system of cause excessive swapping without the test every completing.
> 
> The patch looks good to me, but it would be nice to have another opinion.

I would like another option besides disabling the test unconditionally.
We already have several packages that can simply not be built on
hardware like Jookia's, and although it's an unfortunate situation, I
don't think we should start disabling tests for the substitutes we build
for this reason. Running all the tests possible allows us to provide
valuable feedback to upstream.

How about a comment in the package definition describing the RAM
requirement and how to disable the test, so that users on less powerful
hardware can make the change themselves?

> 
> In any case, it should probably be applied once we have a bit more build
> power, since it causes substantial package rebuilds.
> 
> Andreas
> 
> 

  reply	other threads:[~2016-02-06 20:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-02 21:25 [PATCH] gnu: gdk-pixbuf: Disable pixbuf-scale test Jookia
2016-02-06 15:17 ` Andreas Enge
2016-02-06 20:56   ` Leo Famulari [this message]
2016-02-07 11:15     ` Andreas Enge
2016-02-07 11:27       ` Jookia
2016-02-07 21:17       ` Leo Famulari
2016-02-06 21:04   ` Jookia
2016-02-06 22:24     ` Leo Famulari
2016-02-07 20:06 ` Ludovic Courtès
2016-02-07 21:59   ` Jookia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160206205624.GB6348@jasmine \
    --to=leo@famulari.name \
    --cc=andreas@enge.fr \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).