From: Eric Bavier <ericbavier@openmailbox.org>
To: Christopher Allan Webber <cwebber@dustycloud.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 04/04] gnu: Add assword
Date: Fri, 5 Feb 2016 23:08:06 -0600 [thread overview]
Message-ID: <20160205230806.0e9c0fb7@openmailbox.org> (raw)
In-Reply-To: <87a8nefqgl.fsf@dustycloud.org>
On Fri, 05 Feb 2016 19:49:30 -0800
Christopher Allan Webber <cwebber@dustycloud.org> wrote:
> * gnu/packages/password-utils (assword): New variable.
> ---
> gnu/packages/password-utils.scm | 48 ++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 47 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.scm
[...]
> +(define-public assword
> + (package
> + (name "assword")
> + (version "0.8")
> + (source (origin
> + (method url-fetch)
> + (uri (list
> + (string-append
> + "http://http.debian.net/debian/pool/main/a/assword/"
> + "assword_" version ".orig.tar.gz")))
> + (sha256
> + (base32
> + "0dl4wizbi0r21wxzykm8s445xbvqim5nabi799dmpkdnnh8i546i"))))
> + (arguments
> + `(#:python ,python-2
> + #:tests? #f
Could you add a comment saying why the tests are disabled, even if
just "no tests"?
> + #:phases
> + (modify-phases %standard-phases
> + (add-after 'install 'manpage
> + (lambda* (#:key outputs #:allow-other-keys)
> + (zero? (system* "make" "assword.1"))
> + (install-file
> + "assword.1"
> + (string-append (assoc-ref outputs "out") "/share/man/man1")))))))
You might need to wrap the two steps of this procedure in an "and" so
that the value of the "(zero? (system* ...))" isn't lost.
> + (build-system python-build-system)
> + (inputs
> + `(("python-setuptools" ,python2-setuptools)
> + ("python2-xdo" ,python2-xdo)
> + ("python2-pygpgme" ,python2-pygpgme)
> + ("python2-pygtk" ,python2-pygtk)
> + ("help2man" ,help2man)))
If help2man is only needed for manpage generation it would be best in
native-inputs.
> + (propagated-inputs
> + `(("xclip" ,xclip)))
> + (home-page "https://finestructure.net/assword/")
> + (synopsis "Simple and secure password management system")
Perhaps just "Password manager"?
> + (description "assword is a simple password manager using GPG-wrapped
> +json files. It has a command line interface as well as a very simple
> +graphical interface, which can even \"type\" your passwords into
> +any x11 window.")
s/json/JSON/;s/x11/X11/
Otherwise LGTM!
Thanks,
`~Eric
next prev parent reply other threads:[~2016-02-06 5:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-06 3:49 [PATCH 04/04] gnu: Add assword Christopher Allan Webber
2016-02-06 5:08 ` Eric Bavier [this message]
2016-02-06 23:28 ` Christopher Allan Webber
2016-02-07 16:48 ` Mathieu Lirzin
2016-02-07 17:04 ` Christopher Allan Webber
2016-02-07 23:01 ` Christopher Allan Webber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160205230806.0e9c0fb7@openmailbox.org \
--to=ericbavier@openmailbox.org \
--cc=cwebber@dustycloud.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).