From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: 2 patches Date: Mon, 25 Jan 2016 11:42:35 +0200 Message-ID: <20160125114235.28b3ad99@debian-netbook> References: <20160121105356.40bf43ce@debian-netbook> <20160122202543.GA27435@jasmine> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/wzu=bGrz5Euis_lJ74tzrIM"; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49487) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNdfa-0003Wr-5u for guix-devel@gnu.org; Mon, 25 Jan 2016 04:42:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aNdfW-0000EJ-P5 for guix-devel@gnu.org; Mon, 25 Jan 2016 04:42:46 -0500 Received: from flashner.co.il ([178.62.234.194]:34808) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNdfW-0000EF-ET for guix-devel@gnu.org; Mon, 25 Jan 2016 04:42:42 -0500 In-Reply-To: <20160122202543.GA27435@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Leo Famulari Cc: guix-devel@gnu.org --Sig_/wzu=bGrz5Euis_lJ74tzrIM Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 22 Jan 2016 15:25:43 -0500 Leo Famulari wrote: > On Thu, Jan 21, 2016 at 10:53:56AM +0200, Efraim Flashner wrote: > > I've been holding on to these for a bit, waiting to integrate them befo= re > > submitting them. > >=20 > > cmocka: This is supposed to be used by mpv for running the tests, but t= he > > tests fail. Since mpv works I wasn't super motivated to try to get it to > > work, but I'm guessing other programs might also use it. > >=20 > > python-efl: There are a couple of programs that rely on this, none of w= hich > > are packaged in guix (obviously). The one that I can think of is econnm= an, an > > enlightenment front-end to connman, which I was unable to determine if = it had > > been absorbed by the enlightenemnt codebase in the time since econnman'= s last > > release. > >=20 >=20 > > From 1db7bfc722c0a486cc10cae7853a81484bfb41bc Mon Sep 17 00:00:00 2001 > > From: Efraim Flashner > > Date: Mon, 21 Dec 2015 11:11:01 +0200 > > Subject: [PATCH 1/2] gnu: Add cmocka. > >=20 > > * gnu/packages/video.scm (cmocka): New variable. > > --- > > gnu/packages/video.scm | 23 +++++++++++++++++++++++ > > 1 file changed, 23 insertions(+) =20 >=20 > Is it specific to video programs? Otherwise, I think it should go > somewhere else. How about check.scm? Not video specific, so check.scm does make more sense. =20 > > +(define-public cmocka =20 >=20 > [...] >=20 > > + (arguments > > + `(#:tests? #f)) ; No test target =20 >=20 > Ironic! It does also have the happy benefit of not depending on anything :) >=20 > > From 53336fe873bc639bc2ed65186384e9d6ca7ed34f Mon Sep 17 00:00:00 2001 > > From: Efraim Flashner > > Date: Sun, 15 Nov 2015 13:54:22 +0200 > > Subject: [PATCH] gnu: Add python-efl. > >=20 > > * gnu/packages/enlightenment.scm (python-efl, python2-efl): New variabl= es. > > --- > > gnu/packages/enlightenment.scm | 40 ++++++++++++++++++++++++++++++++++= +++++- > > 1 file changed, 39 insertions(+), 1 deletion(-) =20 >=20 > [...] >=20 > > + (synopsis "Python bindings for EFL") > > + (description > > + "PYTHON-EFL are the python bindings for the whole EFL stack (eo, = evas, =20 > =20 > Can you expand this acronym EFL in the description? ------^ Fixed. > > +ecore, edje, emotion, ethumb and elementary).") > > + (license (list license:lgpl3 license:gpl3)))) =20 >=20 > Perhaps add a short note explaining what parts are under which license? It turns out that while the repo has COPYING and COPYING.LESSER, every file with a copyright notice lists the LGPL so I changed the license listed to that. > Otherwise they both look good to me. >=20 --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --Sig_/wzu=bGrz5Euis_lJ74tzrIM Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJWpe4LAAoJEPTB05F+rO6TY7IP/2tMh3oOIB+Eo5Q+3M6q6TPF D/M6SVBnneg2Q2Iw/+8QNJM/2/U0iTZ4LKcMNayhA167llA5sIDwi7uNDrb42yVW TeKrW0bYRTHJuE3KapB+obD1q5x0oR8gFBVVLCg+KeRgX8VyJhOKeULNaLY+AR4t 77Ha4sd7aY9Rvrt9GOYLq+qdn/405NP4HoAldMg69gtG2bQ3j5/mUy2fANDjkJ0z WxUvTfe5klrD6U2gSjtT90i9z1gN0GkMaLUb1hXPc25/uh1FwYhSZT9DfiE2nfHS 3KINN2wVDN9pGFVDvSQVeHwoh6HPpQKOBOk0LECIQ+EWumsoNs6DH8BIM1h2w6sD epcvLo3GqYYnN3cgKjaD0AFz7q0MfaP8n27y8V06/Rj3vYS2T0ynDghaJSQw0/WF v4hbbV5Gubvv5EEWZml+gu/bFXM6meMLnyubWTxjJKMr6DkgQIyYftNTSNYGrPYf AgzqQ8D5vkPOsLaoiYaXIahNV1A6yLC7W/cXHuK+qiNsCGEwQ/u2OkjgX7sG2y76 rU3MTi7qLTI+cUwvCK6jr4y9CgDPdK8uJNDk3qoyIyBgmVinx9SfW0LQkbf7TE2I AVyxS0gzCP+/nwYiOGcNk3hXTUuFge9BMTCUs3y0tqQnepdbtTaYVYcRq9Eavgm0 k6sPMtZbKpweC3EPBSl3 =RIzM -----END PGP SIGNATURE----- --Sig_/wzu=bGrz5Euis_lJ74tzrIM--