gst-plugins-good

gst-plugins-good

[Efraim Flashner]

[-- Attachment #1.1: Type: text/plain, Size: 974 bytes --]

I've gone back again to try to work out upgrading libvpx to 1.5.0. While now,
as far as I can tell, everything that depends on it no longer breaks as a
result of the update, gst-plugins-good has been giving me serious problems.
After building it ~20 times, here's the one patch that I've gotten to
actually work. I'm not too happy with how it's done, with passing the
--disable-multifile flag. I tried disabling the failing test numerous ways
but that keeps on offering up other error messages that either cause the
build to fail or the test to fail anyway.

ANYWAY, it turns out gstreamer 1.7.x is an unstable release, and 1.8.x should
be coming out "soon". Extremely frusterating to bang my head against this for
so long and find out this is why.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-gst-plugins-good-Update-to-1.7.1.patch --]
[-- Type: text/x-patch, Size: 2365 bytes --]

From 86efc81b4f803215ec198fed414f6bf1820b2942 Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Tue, 19 Jan 2016 13:14:28 +0200
Subject: [PATCH] gnu: gst-plugins-good: Update to 1.7.1.

* gnu/packages/gstreamer.scm (gst-plugins-good): Update to 1.7.1.
[arguments]: Disable failing test, disable multifile.
---
 gnu/packages/gstreamer.scm | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
index b3eeb23..1c788e1 100644
--- a/gnu/packages/gstreamer.scm
+++ b/gnu/packages/gstreamer.scm
@@ -184,16 +184,16 @@ for the GStreamer multimedia library.")
 (define-public gst-plugins-good
   (package
     (name "gst-plugins-good")
-    (version "1.6.1")
+    (version "1.7.1")
     (source
      (origin
       (method url-fetch)
       (uri (string-append
-            "http://gstreamer.freedesktop.org/src/gst-plugins-good/gst-plugins-good-"
-            version ".tar.xz"))
+            "http://gstreamer.freedesktop.org/src/gst-plugins-good/"
+            name "-" version ".tar.xz"))
       (sha256
        (base32
-        "0darc3058kbnql3mnlpizl0sq0hhli7vkm0rpqb7nywz14abim46"))))
+        "1fna7fxrdhqndff8s6rvkxxahz2vv34s44165yd277zmj86jspc2"))))
     (build-system gnu-build-system)
     (inputs
      `(("aalib" ,aalib)
@@ -221,16 +221,16 @@ for the GStreamer multimedia library.")
        ("pkg-config" ,pkg-config)
        ("python-wrapper" ,python-wrapper)))
     (arguments
-     `(#:phases
+     `(#:configure-flags '("--disable-multifile")
+       #:phases
        (modify-phases %standard-phases
          (add-after
           'unpack 'disable-failing-rtprtx-tests
           (lambda _
             ;; Disable rtprtx tests that frequently fail.
-            ;; XXX FIXME: Try removing this for version > 1.6.1.
+            ;; XXX FIXME: Try removing this for version > 1.7.1.
             (substitute* "tests/check/elements/rtprtx.c"
-              (("tcase_add_test \\(tc_chain,\
- (test_rtxsender_max_size_packets|test_rtxreceive_data_reconstruction)\\);" all)
+              (("fail_unless_equals_int\\ \\(nbrtxpackets,\\ 3\\);" all)
                (string-append "/* " all " */")))
             #t)))))
     (home-page "http://gstreamer.freedesktop.org/")
-- 
2.7.0.rc3


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: gst-plugins-good

[Andreas Enge]

On Wed, Jan 20, 2016 at 10:23:20PM +0200, Efraim Flashner wrote:
> ANYWAY, it turns out gstreamer 1.7.x is an unstable release, and 1.8.x should
> be coming out "soon". Extremely frusterating to bang my head against this for
> so long and find out this is why.

Yes, this is why I had decided against updating it in Guix, the test failures
on non-x86 notwithstanding. I think we should wait for the stable release.
What do you and others think?

Andreas

Re: gst-plugins-good

[Andreas Enge]

And in any case, we should probably wait until core-updates is merged.

Andreas

Re: gst-plugins-good

[宋文武]

Andreas Enge <andreas@enge.fr> writes:

> On Wed, Jan 20, 2016 at 10:23:20PM +0200, Efraim Flashner wrote:
>> ANYWAY, it turns out gstreamer 1.7.x is an unstable release, and 1.8.x should
>> be coming out "soon". Extremely frusterating to bang my head against this for
>> so long and find out this is why.
>
> Yes, this is why I had decided against updating it in Guix, the test failures
> on non-x86 notwithstanding. I think we should wait for the stable release.
> What do you and others think?
Sure, we should use stable releases of GStreamer, and 1.6.3 is just
comming out.  I'll do the update later.


Sorry I didn't follow the issue.  What break on master due to the update
of libvpx?  Since hydra is busy with core-updates, I think we can work
on a separate branch, and pick it later after core-updates merged.

Re: gst-plugins-good

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 1422 bytes --]

On Thu, 21 Jan 2016 09:54:25 +0800
iyzsong@member.fsf.org (宋文武) wrote:

> Andreas Enge <andreas@enge.fr> writes:
> 
> > On Wed, Jan 20, 2016 at 10:23:20PM +0200, Efraim Flashner wrote:  
> >> ANYWAY, it turns out gstreamer 1.7.x is an unstable release, and 1.8.x should
> >> be coming out "soon". Extremely frusterating to bang my head against this for
> >> so long and find out this is why.  
> >
> > Yes, this is why I had decided against updating it in Guix, the test failures
> > on non-x86 notwithstanding. I think we should wait for the stable release.
> > What do you and others think?  
> Sure, we should use stable releases of GStreamer, and 1.6.3 is just
> comming out.  I'll do the update later.
> 
> 
> Sorry I didn't follow the issue.  What break on master due to the update
> of libvpx?  Since hydra is busy with core-updates, I think we can work
> on a separate branch, and pick it later after core-updates merged.

Sorry, this was mostly me rambling. I tried back in November to update libvpx
and that broke ffmpeg. Building locally I couldn't get gst-plugins-good to
work with an updated libvpx. I was getting the impression that
gst-plugins-good was "fragile"

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: gst-plugins-good

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 1816 bytes --]

On Thu, 21 Jan 2016 09:54:25 +0800
iyzsong@member.fsf.org (宋文武) wrote:

> Andreas Enge <andreas@enge.fr> writes:
> 
> > On Wed, Jan 20, 2016 at 10:23:20PM +0200, Efraim Flashner wrote:  
> >> ANYWAY, it turns out gstreamer 1.7.x is an unstable release, and 1.8.x should
> >> be coming out "soon". Extremely frusterating to bang my head against this for
> >> so long and find out this is why.  
> >
> > Yes, this is why I had decided against updating it in Guix, the test failures
> > on non-x86 notwithstanding. I think we should wait for the stable release.
> > What do you and others think?  
> Sure, we should use stable releases of GStreamer, and 1.6.3 is just
> comming out.  I'll do the update later.
> 
> 
> Sorry I didn't follow the issue.  What break on master due to the update
> of libvpx?  Since hydra is busy with core-updates, I think we can work
> on a separate branch, and pick it later after core-updates merged.

Against my local gstreamer- and gst-plugin-*-1.7.1 I updated libvpx to 1.5.0
and pulseaudio to 8.0 and gst-plugins-good-1.7.1 built with no issues. When I
compiled gst-plugins-good-1.6.3 against libvpx-1.5.0 and pulseaudio-8.0 I got
the same failure as before (which I forgot to write down), so I'm thinking
this will mostly resolve itself when the gstreamer-1.8 release comes out.

As a side note, I think the interaction between debian's pulseaudio and
guix's pulseaudio where I have no sound from my speakers might be solved with
updating guix's pulseaudio to 8.0. Now to leave sound playing for a while and
see if that's the case.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

GStreamer, PulseAudio and libvpx update

[宋文武]

In the 'gstreamer-update' branch we have following updates:
  libvpx -> 1.5.0
  pulseaudio -> 8.0
  ao -> 1.2.0
  gstreamer (and plugins) -> 1.6.3

This will lead to mess rebuilds.
I have build gst-plugins-good, ffmpeg, mpv and pavucontrol,
tested with pulseaudio-8.0, so I think it's safe to merge.
Or should we start a job for the branch on hydra?


Efraim Flashner <efraim@flashner.co.il> writes:

> On Thu, 21 Jan 2016 09:54:25 +0800
> iyzsong@member.fsf.org (宋文武) wrote:
> [...]
>> 
>> Sorry I didn't follow the issue.  What break on master due to the update
>> of libvpx?  Since hydra is busy with core-updates, I think we can work
>> on a separate branch, and pick it later after core-updates merged.
>
> Against my local gstreamer- and gst-plugin-*-1.7.1 I updated libvpx to 1.5.0
> and pulseaudio to 8.0 and gst-plugins-good-1.7.1 built with no issues. When I
> compiled gst-plugins-good-1.6.3 against libvpx-1.5.0 and pulseaudio-8.0 I got
> the same failure as before (which I forgot to write down), so I'm thinking
> this will mostly resolve itself when the gstreamer-1.8 release comes
> out.
With the gstreamer-update branch merged with current master, I don't
meet any failure for my local x86_64 build of gst-plugins-good-1.6.3.

Do the failure still occur to you?

Re: GStreamer, PulseAudio and libvpx update

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 1229 bytes --]

On Wed, 03 Feb 2016 12:23:24 +0800
iyzsong@member.fsf.org (宋文武) wrote:

> In the 'gstreamer-update' branch we have following updates:
>   libvpx -> 1.5.0
>   pulseaudio -> 8.0
>   ao -> 1.2.0
>   gstreamer (and plugins) -> 1.6.3
> 
> This will lead to mess rebuilds.
> I have build gst-plugins-good, ffmpeg, mpv and pavucontrol,
> tested with pulseaudio-8.0, so I think it's safe to merge.
> Or should we start a job for the branch on hydra?
 
Depending on the number of packages to rebuild, giving hydra a head start of
a day or three is probably a good idea.
 
> Efraim Flashner <efraim@flashner.co.il> writes:
> 
>  [...]  
>  [...]  
>  [...]  
> With the gstreamer-update branch merged with current master, I don't
> meet any failure for my local x86_64 build of gst-plugins-good-1.6.3.
> 
> Do the failure still occur to you?

I just checked out origin/gstreamer-update again and gst-plugins-good failed
to build for me again.
FAIL: elements/splitmux
FAIL: elements/rtprtx

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: GStreamer, PulseAudio and libvpx update

[Andreas Enge]

Hello,

On Wed, Feb 03, 2016 at 12:23:24PM +0800, 宋文武 wrote:
> In the 'gstreamer-update' branch we have following updates:
>   libvpx -> 1.5.0
>   pulseaudio -> 8.0
>   ao -> 1.2.0
>   gstreamer (and plugins) -> 1.6.3

I noticed you merged master into the branch. My opinion is that merging
instead of rebasing messes up the history and makes it rather unclear
what the differences in this branch are. So I would suggest the following:
Delete the branch, create a branch "wip-gstreamer" from security-updates
(not master!), try to build a few packages; after security-updates has been
applied to master, rebase wip-gstreamer and have it built by hydra.

Right now, the priority clearly is to finish security-updates, and we
cannot afford to build a second branch in parallel.

Are these four updates independent? Should they all be built together,
or should we do them one by one? Only 19 packages depend on ao, only 29 on
libvpx, so these could be done separately. Could they even go to master,
or do they depend on gstreamer (or pulseaudio) being updated first? 
pulseaudio has 162 dependent packages, so even these could maybe be built
separately (where by "separately" I mean in a different evaluation).

What do you think?

Andreas

Re: GStreamer, PulseAudio and libvpx update

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 1878 bytes --]

On Wed, 3 Feb 2016 11:25:22 +0100
Andreas Enge <andreas@enge.fr> wrote:

> Hello,
> 
> On Wed, Feb 03, 2016 at 12:23:24PM +0800, 宋文武 wrote:
>  [...]  
> 
> I noticed you merged master into the branch. My opinion is that merging
> instead of rebasing messes up the history and makes it rather unclear
> what the differences in this branch are. So I would suggest the following:
> Delete the branch, create a branch "wip-gstreamer" from security-updates
> (not master!), try to build a few packages; after security-updates has been
> applied to master, rebase wip-gstreamer and have it built by hydra.
> 
> Right now, the priority clearly is to finish security-updates, and we
> cannot afford to build a second branch in parallel.
> 
> Are these four updates independent? Should they all be built together,
> or should we do them one by one? Only 19 packages depend on ao, only 29 on
> libvpx, so these could be done separately. Could they even go to master,
> or do they depend on gstreamer (or pulseaudio) being updated first? 
> pulseaudio has 162 dependent packages, so even these could maybe be built
> separately (where by "separately" I mean in a different evaluation).
> 
> What do you think?
> 
> Andreas
> 

They should all be independant, and AFAIK even the gstreamer updates can be
independant of each other. The problem I ran into before was that
gst-plugins-good didn't compile correctly after updating some of the others.

That said, I think it would be worth it to try to pick off some of the
updates and see if they can be applied without breakage, so I'll see about
again while security-updates get built.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: GStreamer, PulseAudio and libvpx update

[宋文武]

Andreas Enge <andreas@enge.fr> writes:

> Hello,
>
> On Wed, Feb 03, 2016 at 12:23:24PM +0800, 宋文武 wrote:
>> In the 'gstreamer-update' branch we have following updates:
>>   libvpx -> 1.5.0
>>   pulseaudio -> 8.0
>>   ao -> 1.2.0
>>   gstreamer (and plugins) -> 1.6.3
>
> I noticed you merged master into the branch. My opinion is that merging
> instead of rebasing messes up the history and makes it rather unclear
> what the differences in this branch are. So I would suggest the following:
> Delete the branch, create a branch "wip-gstreamer" from security-updates
> (not master!), try to build a few packages; after security-updates has been
> applied to master, rebase wip-gstreamer and have it built by hydra.
Sure, merge does look weird.  Done as you said, thanks for the guide :)
>
> Right now, the priority clearly is to finish security-updates, and we
> cannot afford to build a second branch in parallel.
OK.
>
> Are these four updates independent? Should they all be built together,
> or should we do them one by one? Only 19 packages depend on ao, only 29 on
> libvpx, so these could be done separately. Could they even go to master,
> or do they depend on gstreamer (or pulseaudio) being updated first? 
> pulseaudio has 162 dependent packages, so even these could maybe be built
> separately (where by "separately" I mean in a different evaluation).
>
> What do you think?
Yes, they're independent.  I update gstreamer and add gst-plugins-bad,
the other are from Efraim Flashner's work.  Due to gst-plugins-good
failed to pass some tests with the update of libvpx and pulseaudio,
I think put them together may bring some luck.
well, it seem the test failure of gst-plugins-good is unreleated to
the update...

Re: GStreamer, PulseAudio and libvpx update

[Andreas Enge]

Hello,

On Wed, Feb 03, 2016 at 07:15:11PM +0800, 宋文武 wrote:
> Yes, they're independent.  I update gstreamer and add gst-plugins-bad,
> the other are from Efraim Flashner's work.  Due to gst-plugins-good
> failed to pass some tests with the update of libvpx and pulseaudio,
> I think put them together may bring some luck.
> well, it seem the test failure of gst-plugins-good is unreleated to
> the update...

thanks for getting back to this! I actually had forgotten to mention that
I would be willing to work on this, sorry.

So far, I tried the following: On x86_64, gst-plugins-good builds without
problem with the new version of ao that Efraim already pushed to master
and the new pulseaudio version. One test fails if I also apply the libvpx
update.

So it looks like we could also update pulseaudio in master; according to
"guix refresh -l" there are 168 dependent packages. Is this too much?

In any case, we should now wait for security-updates to be applied to
master, and probably keep the old version of libvpx until after the
gstreamer update.

Andreas

Re: GStreamer, PulseAudio and libvpx update

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 1486 bytes --]

On Wed, 3 Feb 2016 18:43:09 +0100
Andreas Enge <andreas@enge.fr> wrote:

> Hello,
> 
> On Wed, Feb 03, 2016 at 07:15:11PM +0800, 宋文武 wrote:
>  [...]  
> 
> thanks for getting back to this! I actually had forgotten to mention that
> I would be willing to work on this, sorry.
> 
> So far, I tried the following: On x86_64, gst-plugins-good builds without
> problem with the new version of ao that Efraim already pushed to master
> and the new pulseaudio version. One test fails if I also apply the libvpx
> update.
> 
> So it looks like we could also update pulseaudio in master; according to
> "guix refresh -l" there are 168 dependent packages. Is this too much?
> 
> In any case, we should now wait for security-updates to be applied to
> master, and probably keep the old version of libvpx until after the
> gstreamer update.
> 
> Andreas
> 

I tested the ao update which was obviously fine, but libvpx broke
gst-plugins-good. Its nice to know that pulseaudio doesn't break anything, I
assumed I was looking at a 2+ hour build session to really test it so I'm
glad I didn't have to be the one to do it in the end :) Debian managed to
upgrade libvpx to 1.5.0 with gstreamer at 1.6.3 so I'm a bit curious about
how they managed that.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]