From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH 0/1] Add transmission-remote-cli Date: Wed, 20 Jan 2016 20:21:29 -0500 Message-ID: <20160121012129.GA8738@jasmine> References: <8760ynvpof.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41052) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aM3wM-0001bA-M1 for guix-devel@gnu.org; Wed, 20 Jan 2016 20:21:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aM3wJ-0001xE-0w for guix-devel@gnu.org; Wed, 20 Jan 2016 20:21:34 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:51059) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aM3wI-0001wY-To for guix-devel@gnu.org; Wed, 20 Jan 2016 20:21:30 -0500 Content-Disposition: inline In-Reply-To: <8760ynvpof.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?iso-8859-1?Q?Court=E8s?= Cc: guix-devel@gnu.org On Wed, Jan 20, 2016 at 11:42:08PM +0100, Ludovic Courtès wrote: > Leo Famulari skribis: > > > Transmission-remote-cli is a curses-interface client for the > > Transmission bittorrent daemon. > > > > The package is one python script, a man page, and a Bash shell > > completion script. So, I deleted the build phase and replaced the > > install phase. Is that okay? > > Sure. > > In some cases, it’s also possible to use the dumb > ‘trivial-build-system’, but sometimes its dumbness makes it > inconvenient. > > > Also, do we have a standard way to install Zsh shell completions? This > > software provides them, but this package does not. > > I don’t know, we should install them wherever Zsh will look for them. > For Bash, we have bash-completion-directories.patch. Looking into it... > > > * gnu/packages/bittorrent.scm (transmission-remote-cli): New variable. > > Please add a copyright line for yourself. > > Otherwise LGTM. Pushed! > > Thanks! > > Ludo’.