From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 1/2] gnu: Add sonic.
Date: Wed, 13 Jan 2016 22:28:11 -0500
Message-ID: <20160114032811.GB7236@jasmine>
References: <cover.1452576360.git.leo@famulari.name>
	<cover.1452576360.git.leo@famulari.name>
	<5ce5b80290833db46e031d80e43c00fec1399d7b.1452576360.git.leo@famulari.name>
	<87r3hl4lkn.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34909)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aJYZy-0003Mm-FH
	for guix-devel@gnu.org; Wed, 13 Jan 2016 22:28:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aJYZv-0000Uz-6w
	for guix-devel@gnu.org; Wed, 13 Jan 2016 22:28:06 -0500
Received: from out3-smtp.messagingengine.com ([66.111.4.27]:38680)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aJYZv-0000Ut-3J
	for guix-devel@gnu.org; Wed, 13 Jan 2016 22:28:03 -0500
Content-Disposition: inline
In-Reply-To: <87r3hl4lkn.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?iso-8859-1?Q?Court=E8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

On Wed, Jan 13, 2016 at 03:10:16PM +0100, Ludovic Courtès wrote:
> Leo Famulari <leo@famulari.name> skribis:
> 
> > * gnu/packages/audio.scm (sonic): New variable.
> 
> [...]
> 
> > +        #:phases (modify-phases %standard-phases
> > +         (delete 'configure))))
              *-------->|
> 
> There’s a problem here.  :-)

The indentation of the second line, correct?

> 
> > +    (synopsis "Speed up or slow down speech")
> > +    (description "Sonic is a simple algorithm for speeding up or slowing down
> 
> s/is a/implements a/

> 
> > +speech.  However, it's optimized for speed ups of over 2X, unlike previous
> > +algorithms for changing speech rate.  The Sonic library is a very simple ANSI C
> > +library that is designed to easily be integrated into streaming voice
> > +applications, like TTS back ends.
> 
> I would change the last sentence to:
> 
>   Sonic is a C library designed to be easily integrated into streaming
>   voice applications such as text-to-speech (TTS) back ends.
> 
> > +The primary motivation behind Sonic is to enable the blind and visually impaired
> > +to improve their productivity with open source speech engines, like espeak.
>                                 ^‑------------------------------------------^
> Replace with “with speech engines such as eSpeak.”
> 
> > +Sonic can also be used by the sighted.  For example, Sonic can improve the
> > +experience of listening to an audio book on an Android phone.")
> 
> I’d remove these two sentences.
> 
> OK with these changes.

Done.

> 
> Thanks,
> Ludo’.