From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH 2/2] gnu: Add espeak. Date: Wed, 13 Jan 2016 22:27:13 -0500 Message-ID: <20160114032713.GA7236@jasmine> References: <87h9ih4l8n.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34715) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJYZ5-0003E8-1F for guix-devel@gnu.org; Wed, 13 Jan 2016 22:27:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aJYZ1-0000Mg-Ou for guix-devel@gnu.org; Wed, 13 Jan 2016 22:27:10 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:56253) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJYZ1-0000MP-Kb for guix-devel@gnu.org; Wed, 13 Jan 2016 22:27:07 -0500 Content-Disposition: inline In-Reply-To: <87h9ih4l8n.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?iso-8859-1?Q?Court=E8s?= Cc: guix-devel@gnu.org On Wed, Jan 13, 2016 at 03:17:28PM +0100, Ludovic Courtès wrote: > Leo Famulari skribis: > > > * gnu/packages/audio.scm (espeak): New variable. > > If you think eSpeak-ng is not ready yet, or is sufficiently different, > it’s OK to package eSpeak. I'm looking into it. > > > + (native-inputs > > + `(("unzip" ,unzip))) > > + (inputs > > + `(("sonic" ,sonic) > > The “unzip” line is misaligned. The "unzip" line or the "sonic" line? Most of the patches I see use the former style. > > > + ("pulseaudio" ,pulseaudio) > > + ("portaudio" ,portaudio))) > > Dunno if it’s useful to have both, maybe someone more knowledgeable like > Ricardo can answer? I misinterpreted the configure options. It's not useful to have both. If PulseAudio is an input, then eSpeak will always use PulseAudio unless configured not to, in which case PulseAudio should not be an input. PulseAudio stopped working completely on my Debian system a while ago. I decided to keep using ALSA and never looked back (or is it forward, in this case? ;) So, if we are going to target PulseAudio, can a PulseAudio user test that this package works? This should make the computer speak "hello world": $ espeak "hello world" > > > + (synopsis "Software speech synthesizer") > > + (description "eSpeak is a compact software speech synthesizer for > > +English and other languages, for Linux and Windows. eSpeak uses a > ^---------------------^ > Remove. Done. > > In general, we don’t mention proprietary software, and we don’t mention > other OSes, free or not, portability etc., because that’s not what > matters from the viewpoint of an OS provider. > > The rest LGTM! Again, I'll be grateful if a PulseAudio user will test! > > Thanks, > Ludo’.