From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [v3 1/2] gnu: w3m: Update patch to use '-p1'.
Date: Thu, 7 Jan 2016 02:30:02 -0500
Message-ID: <20160107073002.GA31830@jasmine>
References: <9d18197ecca4fe8509e9fa7588f93b9f41ad56e1.1452045889.git.leo@famulari.name>
	<8737ubhu9z.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42824)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aH51P-0002Av-M5
	for guix-devel@gnu.org; Thu, 07 Jan 2016 02:30:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aH51K-0000Hs-8w
	for guix-devel@gnu.org; Thu, 07 Jan 2016 02:30:11 -0500
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:59043)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aH51K-000077-6T
	for guix-devel@gnu.org; Thu, 07 Jan 2016 02:30:06 -0500
Content-Disposition: inline
In-Reply-To: <8737ubhu9z.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?iso-8859-1?Q?Court=E8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

On Wed, Jan 06, 2016 at 11:33:28AM +0100, Ludovic Courtès wrote:
> Leo Famulari <leo@famulari.name> skribis:
> 
> > * gnu/packages/patches/w3m-fix-compile.patch: Update to work with -p1.
> > * gnu/packages/w3m.scm (w3m): Drop patch flag -p0.
> 
> I would rename the patch to, say, ‘w3m-libgc.patch’, for clarity.
> 
> > --- a/gnu/packages/patches/w3m-fix-compile.patch
> > +++ b/gnu/packages/patches/w3m-fix-compile.patch
> > @@ -1,15 +1,27 @@
> > +From 371f256f5f300b01be228a6fd95884ea475965fc Mon Sep 17 00:00:00 2001
> > +From: Leo Famulari <leo@famulari.name>
> > +Date: Tue, 5 Jan 2016 16:57:29 -0500
> > +Subject: [PATCH 1/4] fix compile
> > +
> >  https://bugs.archlinux.org/task/33397
> 
> Could you remove the Git header and write something like:
> 
>   This patch fixes w3m compilation with libgc > X.Y.
> 
> (If I understand correctly what it does.)

Done.

> 
> However, I’m surprised this is needed since libgc hasn’t changed lately?

It's for libgc-7.2, released 2012-05-11.

You may also notice the substitution of "file_handle" in w3m's package
definition. That's because glibc decided to start using the identifier
"file_handle" in 2011 [0]. The problem was reported to w3m on the last
day of 2011 [1]. It was patched in the distros in 2012 but nothing from
upstream.

[0]
http://repo.or.cz/w/glibc.git/commitdiff/158648c0bdda281e252a27c0200dd0ea6f4e0215

[1]
http://sourceforge.net/p/w3m/patches/58/

> 
> Thanks,
> Ludo’.