From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: [PATCH] guix pypi importer: Add ending as an optional argument to pypi-uri. Date: Tue, 5 Jan 2016 11:58:37 +0200 Message-ID: <20160105115837.24eaf361@debian-netbook> References: <1451856997-13507-1-git-send-email-swedebugia@riseup.net> <568B1414.9010107@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/DrsRHV4V=yxjLMd7GvvqGcD"; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57537) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGOOk-0007SP-US for guix-devel@gnu.org; Tue, 05 Jan 2016 04:59:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aGOOh-0001Ds-OW for guix-devel@gnu.org; Tue, 05 Jan 2016 04:59:26 -0500 Received: from flashner.co.il ([178.62.234.194]:49823) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGOOh-0001Dc-Hd for guix-devel@gnu.org; Tue, 05 Jan 2016 04:59:23 -0500 In-Reply-To: <568B1414.9010107@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Cyril Roelandt Cc: guix-devel@gnu.org --Sig_/DrsRHV4V=yxjLMd7GvvqGcD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, 5 Jan 2016 01:53:40 +0100 Cyril Roelandt wrote: > On 01/03/2016 10:36 PM, swedebugia wrote: > > --- > > guix/build-system/python.scm | 17 ++++++++++++----- > > 1 file changed, 12 insertions(+), 5 deletions(-) > >=20 > > diff --git a/guix/build-system/python.scm b/guix/build-system/python.scm > > index 2532210..09074ce 100644 > > --- a/guix/build-system/python.scm > > +++ b/guix/build-system/python.scm > > @@ -41,13 +41,20 @@ > > ;; > > ;; Code: > > =20 > > -(define (pypi-uri name version) > > +(define* (pypi-uri name version > > + #:optional > > + ending) =20 >=20 > Could we use "tar.gz" as the default value of ENDING as to avoid the > need for a test in this function? >=20 It already does that with the patch If there's no change then it defaults = to .tar.gz. Could part of the patch be changed to: #:optional (ending ".tar.gz")) ? > Also, it would be nice to update the pypi importer as well, so that it > detects the right suffix. >=20 > I also think "ending" should be renamed to "extension" or something like > that. >=20 > WDYT? >=20 I like extension too. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --Sig_/DrsRHV4V=yxjLMd7GvvqGcD Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJWi5PNAAoJEPTB05F+rO6TdyQP/18mn14TtXOc2D5yUxgnTznw g4AdLCdv5/mOqY+QgDRKHZj1Xv0OwLTr+UCS6z+eIcFJBpYFi0QNYHqyKvDAwEgr pqIUEeqq3GVcOcvOsZkaGMqeNMCGlBxKb2Ph6LueahNoy2xPcI2B4X02zyqY9swD QPe0k7FKYpd9Z2S+vl/sWtEpzXIU1IxRYXPoVDtzJUXoixEbqCofw57cGdcJZ/Md Ki8CO2zJDzpxYLCgITnBwZVqQ6Q3cSfal/bubm/Ds06qe6zCibxTeTKf1ZyvHKuj ZhNLGUwsfbXqnZ2VkaEszzpMtNqPKhiG7LxgjhUDCctS9+u7eg74dRTSfa8MYN6/ /gPXJSPwOWRA78BXZo6uyJozSfwtE0SgpDeEsJbwXCitr7Nws83GtElHzmFKhTcK 5frK1WGjXOMDuWNL1CCI9x4FmruwhJqJ9Hgc3VambylKg7QIOXu1zisTBvqFP2gL zymcTXQM62SD30zF38NqckiFWwgUkOoljFtPrwEGGWPCY+w7RtQxDMcuhaISrOvr drriPlpkQeYW0SBYJ7b5zfG8oLURRbjQXFKAO1r7/JRX1N9fxzpJ7JFyqo/tBSu9 Bqt/75wJAb6WymDZvu3577GnG+vd0XXGhA3W/4F7Mew6fdDWf88FcfsuIyytmdYF NJjyW/NEMPcRAETbkKe+ =ze7w -----END PGP SIGNATURE----- --Sig_/DrsRHV4V=yxjLMd7GvvqGcD--