Re: [PATCH] guix pypi importer: Add ending as an optional argument to pypi-uri.

[Efraim Flashner <efraim@flashner.co.il>]

[-- Attachment #1: Type: text/plain, Size: 1375 bytes --]

On Tue, 5 Jan 2016 01:53:40 +0100
Cyril Roelandt <tipecaml@gmail.com> wrote:

> On 01/03/2016 10:36 PM, swedebugia wrote:
> > ---
> >  guix/build-system/python.scm | 17 ++++++++++++-----
> >  1 file changed, 12 insertions(+), 5 deletions(-)
> > 
> > diff --git a/guix/build-system/python.scm b/guix/build-system/python.scm
> > index 2532210..09074ce 100644
> > --- a/guix/build-system/python.scm
> > +++ b/guix/build-system/python.scm
> > @@ -41,13 +41,20 @@
> >  ;;
> >  ;; Code:
> >  
> > -(define (pypi-uri name version)
> > +(define* (pypi-uri name version
> > +                  #:optional
> > +                  ending)  
> 
> Could we use "tar.gz" as the default value of ENDING as to avoid the
> need for a test in this function?
> 
It already does that with the patch  If there's no change then it defaults to .tar.gz. Could part of the patch be changed to:
#:optional (ending ".tar.gz")) ?

> Also, it would be nice to update the pypi importer as well, so that it
> detects the right suffix.
> 
> I also think "ending" should be renamed to "extension" or something like
> that.
> 
> WDYT?
> 

I like extension too.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]