From: Leo Famulari <leo@famulari.name>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/2] gnu: Add cuetools.
Date: Tue, 29 Dec 2015 19:55:47 -0500 [thread overview]
Message-ID: <20151230005547.GA5737@jasmine> (raw)
In-Reply-To: <87io3gzvj8.fsf@gnu.org>
On Wed, Dec 30, 2015 at 12:26:19AM +0100, Ludovic Courtès wrote:
> Leo Famulari <leo@famulari.name> skribis:
>
> > * gnu/packages/audio.scm (cuetools): New variable.
>
> [...]
>
> > + (modify-phases %standard-phases
> > + (add-after 'unpack 'bootstrap
> > + (lambda _ (zero? (system* "autoreconf" "-vfi")))))))
>
> Note that, as per a recent rule, the “(lambda” should be aligned with
> the ‘d’ of ‘add-after’.
Done.
>
> > + (home-page "https://github.com/svend/cuetools")
> > + (license license:gpl2)))
>
> AFAICS, source file headers do not mention a specific GPL version; thus,
> it should be ‘gpl2+’.
Done.
>
> Otherwise LGTM, thanks!
Pushed as 6da16993eb.
>
> Ludo’.
next prev parent reply other threads:[~2015-12-30 0:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-28 5:32 [PATCH 0/2] Add cuetools and shntool Leo Famulari
2015-12-28 5:32 ` [PATCH 1/2] gnu: Add cuetools Leo Famulari
2015-12-29 23:26 ` Ludovic Courtès
2015-12-30 0:55 ` Leo Famulari [this message]
2015-12-28 5:32 ` [PATCH 2/2] gnu: Add shntool Leo Famulari
2015-12-29 23:28 ` Ludovic Courtès
2015-12-30 0:56 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151230005547.GA5737@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).