From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: [PATCH 04/10] gnu: Add python-keystoneclient. Date: Sun, 27 Dec 2015 12:13:52 +0200 Message-ID: <20151227121352.61cb557c@debian-netbook> References: <1449153811-32039-1-git-send-email-efraim@flashner.co.il> <1449153811-32039-5-git-send-email-efraim@flashner.co.il> <20151207212658.06ad1a0c@debian-netbook> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/nlJcwY.Ng8ldl3Y3_f9iT+o"; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53769) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aD8OM-0003Qi-Nw for guix-devel@gnu.org; Sun, 27 Dec 2015 05:17:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aD8OK-0000L9-Vc for guix-devel@gnu.org; Sun, 27 Dec 2015 05:17:34 -0500 Received: from flashner.co.il ([178.62.234.194]:56813) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aD8OK-0000L0-JL for guix-devel@gnu.org; Sun, 27 Dec 2015 05:17:32 -0500 In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel@gnu.org --Sig_/nlJcwY.Ng8ldl3Y3_f9iT+o Content-Type: multipart/mixed; boundary="MP_/KuA9d.TCOvg3Ir3YVkxfJXj" --MP_/KuA9d.TCOvg3Ir3YVkxfJXj Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Fri, 11 Dec 2015 15:15:35 +0100 Ricardo Wurmus wrote: > Efraim Flashner writes: >=20 > [...] =20 >=20 > [...] =20 >=20 > [...] =20 > =20 > [...] =20 > =20 > [...] =20 > =20 > > (define-public python2-oslo.utils > > (package-with-python2 python-oslo.utils)) > > + > > +(define-public python-keystoneclient > > + (package > > + (name "python-keystoneclient") > > + (version "1.8.1") > > + (source > > + (origin > > + (method url-fetch) > > + (uri (pypi-uri "python-keystoneclient" version)) > > + (sha256 > > + (base32 > > + "1w4csvkah67rfpxylxnvs2s3594i0f9isy8pf4gnsqs5zirvjaa4")))) = =20 >=20 > The indentation is a bit off. If this was the only thing I could fix > this before pushing, but I still have some other comments. >=20 > > + (build-system python-build-system) > > + (native-inputs > > + `(("python-setuptools" ,python-setuptools) > > + ;; and some packages for the tests > > + ("openssl" ,openssl) > > + ("python-coverage" ,python-coverage) > > + ("python-discover" ,python-discover) > > + ("python-fixtures" ,python-fixtures) > > + ("python-hacking" ,python-hacking) > > + ("python-keyring" ,python-keyring) > > + ("python-lxml" ,python-lxml) > > + ("python-mock" ,python-mock) > > + ("python-mox3" ,python-mox3) > > + ("python-oauthlib" ,python-oauthlib) > > + ("python-oslosphinx" ,python-oslosphinx) > > + ("python-oslotest" ,python-oslotest) > > + ("python-pycrypto" ,python-pycrypto) > > + ("python-requests-mock" ,python-requests-mock) > > + ("python-sphinx" ,python-sphinx) =20 >=20 > This doesn=E2=80=99t look like it=E2=80=99s needed for the tests. Maybe = you could move > it above the comment (or remove the comment)? Do you mean python-sphinx or all of the above? (Just read the next one about python-sphinx being for documentation, moved that one.) Openssl isn't a declared test dependency, but testing failed without it. >=20 > > + ("python-temptest-lib" ,python-tempest-lib) > > + ("python-testrepository" ,python-testrepository) > > + ("python-testresources" ,python-testresources) > > + ("python-testtools" ,python-testtools) > > + ("python-webob" ,python-webob))) =20 >=20 > Wow! That=E2=80=99s a very long list of test dependencies. Thanks for y= our > patience in tracking them down rather than taking the easy route of > disabling tests! Openstack is pretty good about declaring dependencies, with both a requirements.txt and a test-requirements.txt in the source tree, and that helped a lot. https://git.openstack.org/cgit/openstack/python-keystoneclient/tree/?h=3D1.= 8.1 >=20 > > + (propagated-inputs > > + `(("python-babel" ,python-babel) > > + ("python-debtcollector" ,python-debtcollector) > > + ("python-iso8601" ,python-iso8601) > > + ("python-netaddr" ,python-netaddr) > > + ("python-oslo.config" ,python-oslo.config) > > + ("python-oslo.i18n" ,python-oslo.i18n) > > + ("python-oslo.serialization" ,python-oslo.serialization) > > + ("python-oslo.utils" ,python-oslo.utils) > > + ("python-pbr" ,python-pbr) > > + ("python-prettytable" ,python-prettytable) > > + ("python-requests" ,python-requests) > > + ("python-six" ,python-six) > > + ("python-stevedore" ,python-stevedore))) > > + (home-page "http://www.openstack.org/") > > + (synopsis "Client Library for OpenStack Identity") > > + (description > > + "Python-keystoneclient is the identity service used by OpenStack for > > +authentication (authN) and high-level authorization (authZ). It curre= ntly > > +supports token-based authN with user/service authZ, and is scalable to= support > > +OAuth, SAML, and OpenID in future versions. Out of the box, Keystone = uses > > +SQLite for its identity store database, with the option to connect to = external > > +LDAP.") =20 >=20 > I wonder: if it does uses Sqlite by default, how come sqlite is not > among the inputs? Does it bundle sqlite sources? Or does it just fail > by default unless sqlite is installed? >=20 It doesn't bundle sqlite, and it looks like the included description doesn't differentiate too much between keystone and keystoneclient. As per the name, keystoneclient connects to keystone, which would need sqlite. > > + (license asl2.0))) > > + > > +(define-public python2-keystoneclient > > + (let ((keystoneclient (package-with-python2 python-keystoneclient))) > > + (package (inherit keystoneclient) > > + (native-inputs > > + `(("python2-oauthlib" ,python2-oauthlib) > > + ,@(alist-delete > > + "python-oauthlib" > > + (package-native-inputs keystoneclient))))))) =20 >=20 > Okay! >=20 > ~~ Ricardo 2.0.0 was tagged about 4 weeks ago, but it ended up needing more packages packaged and more dependencies updated and it looks like a project for another time. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --MP_/KuA9d.TCOvg3Ir3YVkxfJXj Content-Type: text/x-patch Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename=0001-gnu-Add-python-keystoneclient.patch =46rom 63b7c408bfd97a79554907f527469ab93826d390 Mon Sep 17 00:00:00 2001 From: Efraim Flashner Date: Mon, 23 Nov 2015 20:29:12 +0200 Subject: [PATCH 1/9] gnu: Add python-keystoneclient. * gnu/packages/openstack.scm (python-keystoneclient) (python2-keystoneclient): New variables. --- gnu/packages/openstack.scm | 73 ++++++++++++++++++++++++++++++++++++++++++= +++- 1 file changed, 72 insertions(+), 1 deletion(-) diff --git a/gnu/packages/openstack.scm b/gnu/packages/openstack.scm index 2578292..32507ad 100644 --- a/gnu/packages/openstack.scm +++ b/gnu/packages/openstack.scm @@ -19,12 +19,14 @@ =20 (define-module (gnu packages openstack) #:use-module (gnu packages python) + #:use-module (gnu packages tls) #:use-module (gnu packages version-control) #:use-module (guix build-system python) #:use-module (guix download) #:use-module ((guix licenses) #:select (asl2.0)) - #:use-module (guix packages)) + #:use-module (guix packages) + #:use-module (srfi srfi-1)) =20 (define-public python-bandit (package @@ -679,3 +681,72 @@ handling.") =20 (define-public python2-oslo.utils (package-with-python2 python-oslo.utils)) + +(define-public python-keystoneclient + (package + (name "python-keystoneclient") + (version "1.8.1") + (source + (origin + (method url-fetch) + (uri (pypi-uri "python-keystoneclient" version)) + (sha256 + (base32 + "1w4csvkah67rfpxylxnvs2s3594i0f9isy8pf4gnsqs5zirvjaa4")))) + (build-system python-build-system) + (native-inputs + `(("python-setuptools" ,python-setuptools) + ("python-sphinx" ,python-sphinx) + ;; and some packages for the tests + ("openssl" ,openssl) + ("python-coverage" ,python-coverage) + ("python-discover" ,python-discover) + ("python-fixtures" ,python-fixtures) + ("python-hacking" ,python-hacking) + ("python-keyring" ,python-keyring) + ("python-lxml" ,python-lxml) + ("python-mock" ,python-mock) + ("python-mox3" ,python-mox3) + ("python-oauthlib" ,python-oauthlib) + ("python-oslosphinx" ,python-oslosphinx) + ("python-oslotest" ,python-oslotest) + ("python-pycrypto" ,python-pycrypto) + ("python-requests-mock" ,python-requests-mock) + ("python-temptest-lib" ,python-tempest-lib) + ("python-testrepository" ,python-testrepository) + ("python-testresources" ,python-testresources) + ("python-testtools" ,python-testtools) + ("python-webob" ,python-webob))) + (propagated-inputs + `(("python-babel" ,python-babel) + ("python-debtcollector" ,python-debtcollector) + ("python-iso8601" ,python-iso8601) + ("python-netaddr" ,python-netaddr) + ("python-oslo.config" ,python-oslo.config) + ("python-oslo.i18n" ,python-oslo.i18n) + ("python-oslo.serialization" ,python-oslo.serialization) + ("python-oslo.utils" ,python-oslo.utils) + ("python-pbr" ,python-pbr) + ("python-prettytable" ,python-prettytable) + ("python-requests" ,python-requests) + ("python-six" ,python-six) + ("python-stevedore" ,python-stevedore))) + (home-page "http://www.openstack.org/") + (synopsis "Client Library for OpenStack Identity") + (description + "Python-keystoneclient is the identity service used by OpenStack for +authentication (authN) and high-level authorization (authZ). It currently +supports token-based authN with user/service authZ, and is scalable to sup= port +OAuth, SAML, and OpenID in future versions. Out of the box, Keystone uses +SQLite for its identity store database, with the option to connect to exte= rnal +LDAP.") + (license asl2.0))) + +(define-public python2-keystoneclient + (let ((keystoneclient (package-with-python2 python-keystoneclient))) + (package (inherit keystoneclient) + (native-inputs + `(("python2-oauthlib" ,python2-oauthlib) + ,@(alist-delete + "python-oauthlib" + (package-native-inputs keystoneclient))))))) --=20 2.6.4 --MP_/KuA9d.TCOvg3Ir3YVkxfJXj-- --Sig_/nlJcwY.Ng8ldl3Y3_f9iT+o Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJWf7ngAAoJEPTB05F+rO6T5VMP/38n6UOpW5QJDd5d8vHV+8ec gzJtS6hYgiM0ITD5gIXSXd0UtpYQdyJeKfYwyNpCZlDLx7tVO6S1lzIK+5DkadQO FT2oL8MYiI7xxW3/So9GY4GeiJYIcvvuUf+oq9dlI64QosfEE4KdFyLvflc0gINJ 53K3NVyg2ejFbl5o3uO2FfmFRERdbpxAsrFh6rTYf18UGmaurCKGnvZLrbdS8NDG fFwpxyFnGeB/o2I9Ll385gdx4NvnA2+kv6MkdQJK4xIe8/ZR7TA3XjmTSLI1/ig0 Hwx0cJ9B4ks3wle5HHY5UM8+08KrTN1HD3yPdMvNYuQG0dqpyc4HLKgS3YOgoZA9 8G7E7Mhwvfn/yrTO+V/4IXGJ1fIvHm06RV9ZDBZCygz5MlbsdvmCSkF9H/aSyVIl CDfeEyC5bRQ/aar1TJfhkXNSuDqEGUSoB+IZjc0wcXHJJAiyFEP2y+kWcJgq3gv5 J1TZoA5ripjSEmROHScFNXjXW5kqYyUef9O8m7QwSuHnqEK8uMzYot7TKRNTCcTx E3L7VOHEMi+d35h0eYD32PlROz39JQH4c56MGNliVAII9NIHPB4lBa2tt3cX1LYK XVuhUqk4mF3pW/b3vatHSTqKIH2j+3zXXqasYzZamI3b14YyhpfNivk1G94PGymu yJnEyJCQLYch7m/Dfbbq =nJAf -----END PGP SIGNATURE----- --Sig_/nlJcwY.Ng8ldl3Y3_f9iT+o--