Re: [PATCH 02/10] gnu: Add python-wheel.

[Efraim Flashner <efraim@flashner.co.il>]

[-- Attachment #1.1: Type: text/plain, Size: 2018 bytes --]

On Fri, 11 Dec 2015 15:07:34 +0100
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> wrote:

> Efraim Flashner <efraim@flashner.co.il> writes:
>  [...]   
> 
> The indentation is wrong here (and affects all following lines of this
> sub-expression).
> 
>  [...]  
> 
> I also think that the indentation is wrong here.  My Emacs aligns
> “(base32” with the “s” of “(sha256”.
>

I've fixed this so now the tabulation is correct and the base32 aligns with
the sha256. I've seen base32 with both 1 and 2 spaces but I personally don't
have a preference as long as the hash doesn't go beyond 80 spaces.

> 
> > +             "032k1ajijbqnv0z0k88bhf75mdimi18fcmm28mss90610lw3bbga"))))
> > +  (build-system python-build-system)
> > +  (native-inputs
> > +   `(("python-setuptools" ,python-setuptools)
> > +     ("python-jsonschema" ,python-jsonschema)
> > +     ("python-pytest-cov" ,python-pytest-cov)))
> > +  (home-page "https://bitbucket.org/pypa/wheel/")
> > +  (synopsis "Built-package format for Python")  
> 
> I don’t know what this means.

This I copied directly from their website. From a reference that I know, .deb
files have everything they need to be installed in a system, they just need
to be unpacked and the files placed in their locations.

> 
>  [...]  
> 
> Okay, but what does this package provide?  Is it a library to create
> or inspect wheel packages?

This specifically I don't know, but I assume it is to create and use wheel bundles.

> I apologise for not bringing this up earlier, but this is the first time
> I actually read the description.  (Before that I only paid attention to
> the input types.)
> 
> ~~ Ricardo

Not a problem :)

I've expanded the description and added @code{...} tags to try to make it clearer.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0009-gnu-python-wheel-Clarify-description.patch --]
[-- Type: text/x-patch, Size: 2726 bytes --]

From fc5ca92c9bc0466e581cf806174104a5112346cc Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Sun, 27 Dec 2015 09:39:51 +0200
Subject: [PATCH 9/9] gnu: python-wheel: Clarify description.

* gnu/packages/python.scm (python-wheel): Do it.
---
 gnu/packages/python.scm | 42 +++++++++++++++++++++++-------------------
 1 file changed, 23 insertions(+), 19 deletions(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 50137bd..3ed14b5 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -2146,25 +2146,29 @@ with sensible defaults out of the box.")
   (package
     (name "python-wheel")
     (version "0.26.0")
-      (source
-        (origin
-          (method url-fetch)
-          (uri (pypi-uri "wheel" version))
-          (sha256
-            (base32
-             "032k1ajijbqnv0z0k88bhf75mdimi18fcmm28mss90610lw3bbga"))))
-  (build-system python-build-system)
-  (native-inputs
-   `(("python-setuptools" ,python-setuptools)
-     ("python-jsonschema" ,python-jsonschema)
-     ("python-pytest-cov" ,python-pytest-cov)))
-  (home-page "https://bitbucket.org/pypa/wheel/")
-  (synopsis "Built-package format for Python")
-  (description
-   "A wheel is a ZIP-format archive with a specially formatted filename and the
-.whl extension.  It is designed to contain all the files for a PEP 376
-compatible install in a way that is very close to the on-disk format.")
-  (license license:expat)))
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "wheel" version))
+        (sha256
+         (base32
+          "032k1ajijbqnv0z0k88bhf75mdimi18fcmm28mss90610lw3bbga"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("python-setuptools" ,python-setuptools)
+       ("python-jsonschema" ,python-jsonschema)
+       ("python-pytest-cov" ,python-pytest-cov)))
+    (home-page "https://bitbucket.org/pypa/wheel/")
+    (synopsis "Built-package format for Python")
+    (description
+     "A wheel is a ZIP-format archive with a specially formatted filename and
+the @code{.whl} extension.  It is designed to contain all the files for a PEP
+376 compatible install in a way that is very close to the on-disk format.  Many
+packages will be properly installed with only the @code{Unpack} step and the
+unpacked archive preserves enough information to @code{Spread} (copy data and
+scripts to their final locations) at any later time.  Wheel files can be
+installed with a newer @code{pip} or with wheel's own command line utility.")
+    (license license:expat)))
 
 (define-public python2-wheel
   (package-with-python2 python-wheel))
-- 
2.6.4


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]