[PATCH] gnu: Add mpv-minimal.

[PATCH] gnu: Add mpv-minimal.

[Alex Kost]

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

I cry every time I see samba during updating my profile, so I wonder if
it is acceptable to have "mpv-minimal" which is less heavy on
dependencies.  If so, perhaps the other people have ideas what inputs
may also be removed, thanks.


[-- Attachment #2: 0001-gnu-Add-mpv-minimal.patch --]
[-- Type: text/x-patch, Size: 1535 bytes --]

From fdcbbff10839dfd2d086d7a022488a9cf75db5c9 Mon Sep 17 00:00:00 2001
From: Alex Kost <alezost@gmail.com>
Date: Fri, 4 Dec 2015 18:57:10 +0300
Subject: [PATCH] gnu: Add mpv-minimal.

* gnu/packages/video.scm (mpv-minimal): New variable.
---
 gnu/packages/video.scm | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 928e9ef..36d433d 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -6,6 +6,7 @@
 ;;; Copyright © 2015 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2015 Andy Patterson <ajpatter@uwaterloo.ca>
 ;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
+;;; Copyright © 2015 Alex Kost <alezost@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -78,7 +79,8 @@
   #:use-module (gnu packages xml)
   #:use-module (gnu packages xorg)
   #:use-module (gnu packages yasm)
-  #:use-module (gnu packages zip))
+  #:use-module (gnu packages zip)
+  #:use-module (srfi srfi-1))
 
 (define-public aalib
   (package
@@ -770,6 +772,12 @@ fork of mplayer2 and MPlayer.  It shares some features with the former
 projects while introducing many more.")
     (license license:gpl2+)))
 
+(define-public mpv-minimal
+  (package (inherit mpv)
+    (name "mpv-minimal")
+    (inputs (alist-delete "samba" (package-inputs mpv)))
+    (synopsis "Audio and video player (without extra dependencies)")))
+
 (define-public libvpx
   (package
     (name "libvpx")
-- 
2.6.3

Re: [PATCH] gnu: Add mpv-minimal.

[Andreas Enge]

On Fri, Dec 04, 2015 at 07:08:36PM +0300, Alex Kost wrote:
> I cry every time I see samba during updating my profile, so I wonder if
> it is acceptable to have "mpv-minimal" which is less heavy on
> dependencies.  If so, perhaps the other people have ideas what inputs
> may also be removed, thanks.

Or would it make sense to remove samba altogether from the regular mpv
package?

Andreas

Re: [PATCH] gnu: Add mpv-minimal.

[Taylan Ulrich Bayırlı/Kammer]

Andreas Enge <andreas@enge.fr> writes:

> On Fri, Dec 04, 2015 at 07:08:36PM +0300, Alex Kost wrote:
>> I cry every time I see samba during updating my profile, so I wonder if
>> it is acceptable to have "mpv-minimal" which is less heavy on
>> dependencies.  If so, perhaps the other people have ideas what inputs
>> may also be removed, thanks.
>
> Or would it make sense to remove samba altogether from the regular mpv
> package?

As an mpv user and the one who initially packaged it and added samba
(because I simply added all optional dependencies), I don't mind.

Taylan

Re: [PATCH] gnu: Add mpv-minimal.

[Alex Kost]

Andreas Enge (2015-12-04 20:13 +0300) wrote:

> On Fri, Dec 04, 2015 at 07:08:36PM +0300, Alex Kost wrote:
>> I cry every time I see samba during updating my profile, so I wonder if
>> it is acceptable to have "mpv-minimal" which is less heavy on
>> dependencies.  If so, perhaps the other people have ideas what inputs
>> may also be removed, thanks.
>
> Or would it make sense to remove samba altogether from the regular mpv
> package?

I'm personally for it, but there may be users who need mpv with samba
support, so I'm not sure if it is right.  I thought that default Guix
packages should be full-featured, no?

-- 
Alex

Re: [PATCH] gnu: Add mpv-minimal.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 1035 bytes --]

On Sat, 05 Dec 2015 21:49:53 +0300
Alex Kost <alezost@gmail.com> wrote:

> Andreas Enge (2015-12-04 20:13 +0300) wrote:
> 
> > On Fri, Dec 04, 2015 at 07:08:36PM +0300, Alex Kost wrote:  
> >> I cry every time I see samba during updating my profile, so I wonder if
> >> it is acceptable to have "mpv-minimal" which is less heavy on
> >> dependencies.  If so, perhaps the other people have ideas what inputs
> >> may also be removed, thanks.  
> >
> > Or would it make sense to remove samba altogether from the regular mpv
> > package?  
> 
> I'm personally for it, but there may be users who need mpv with samba
> support, so I'm not sure if it is right.  I thought that default Guix
> packages should be full-featured, no?
> 

we could rename the current one mpv-network-support or something similar.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] gnu: Add mpv-minimal.

[Andreas Enge]

On Sat, Dec 05, 2015 at 09:28:43PM +0200, Efraim Flashner wrote:
> > I'm personally for it, but there may be users who need mpv with samba
> > support, so I'm not sure if it is right.  I thought that default Guix
> > packages should be full-featured, no?

No idea. I am not sure we need windows support :-)  (or whatever this is
exactly). If nobody needs it and some feel disturbed, we may as well
remove it for the time being and think again once someone requests it.

> we could rename the current one mpv-network-support or something similar.

Rather not; the default package should have the default name.

Andreas

Re: [PATCH] gnu: Add mpv-minimal.

[Alex Kost]

Andreas Enge (2015-12-05 23:49 +0300) wrote:

> Alex Kost <alezost@gmail.com> writes:
>> I'm personally for it, but there may be users who need mpv with samba
>> support, so I'm not sure if it is right.  I thought that default Guix
>> packages should be full-featured, no?
>
> No idea. I am not sure we need windows support :-)  (or whatever this is
> exactly). If nobody needs it and some feel disturbed, we may as well
> remove it for the time being and think again once someone requests it.

I agree!

Mark H Weaver (2015-12-19 03:02 +0300) wrote:

> Alex Kost <alezost@gmail.com> writes:
>> What about removing samba input instead as Andreas suggested:
>> <http://lists.gnu.org/archive/html/guix-devel/2015-12/msg00092.html>
>
> I have no objection to this, but then I'm not an 'mpv' user and I don't
> know what functionality would be lost.  I'll leave it to others to
> decide.

I am an mpv user and I would really like to get rid of this samba
output, as it is heavy-weight and IIUC the lost functionality would be
an impossibility to play audio/video files from remote resources
connected using samba (which most likely are "MS Windows" partitions).

So if other people do not object, I'm going to remove 'samba' output
from 'mpv' package.

-- 
Alex

Re: [PATCH] gnu: Add mpv-minimal.

[Leo Famulari]

On Wed, Dec 23, 2015 at 11:26:47AM +0300, Alex Kost wrote:
> Andreas Enge (2015-12-05 23:49 +0300) wrote:
> 
> > Alex Kost <alezost@gmail.com> writes:
> >> I'm personally for it, but there may be users who need mpv with samba
> >> support, so I'm not sure if it is right.  I thought that default Guix
> >> packages should be full-featured, no?
> >
> > No idea. I am not sure we need windows support :-)  (or whatever this is
> > exactly). If nobody needs it and some feel disturbed, we may as well
> > remove it for the time being and think again once someone requests it.
> 
> I agree!
> 
> Mark H Weaver (2015-12-19 03:02 +0300) wrote:
> 
> > Alex Kost <alezost@gmail.com> writes:
> >> What about removing samba input instead as Andreas suggested:
> >> <http://lists.gnu.org/archive/html/guix-devel/2015-12/msg00092.html>
> >
> > I have no objection to this, but then I'm not an 'mpv' user and I don't
> > know what functionality would be lost.  I'll leave it to others to
> > decide.
> 
> I am an mpv user and I would really like to get rid of this samba
> output, as it is heavy-weight and IIUC the lost functionality would be
> an impossibility to play audio/video files from remote resources
> connected using samba (which most likely are "MS Windows" partitions).
> 
> So if other people do not object, I'm going to remove 'samba' output
> from 'mpv' package.

I suggest making it a separate output so that users can get the
functionality if they need but the default package does not include it.

I can try it in the next couple of days — I've been meaning to learn how
to create multiple outputs for a package.

> 
> -- 
> Alex
> 

Re: [PATCH] gnu: Add mpv-minimal.

[Alex Kost]

Leo Famulari (2015-12-23 22:29 +0300) wrote:

> On Wed, Dec 23, 2015 at 11:26:47AM +0300, Alex Kost wrote:
>> I am an mpv user and I would really like to get rid of this samba
>> output, as it is heavy-weight and IIUC the lost functionality would be
>> an impossibility to play audio/video files from remote resources
>> connected using samba (which most likely are "MS Windows" partitions).
>>
>> So if other people do not object, I'm going to remove 'samba' output
>> from 'mpv' package.
>
> I suggest making it a separate output so that users can get the
> functionality if they need but the default package does not include it.
>
> I can try it in the next couple of days — I've been meaning to learn how
> to create multiple outputs for a package.

I don't see how it can be done using a separate output (but I don't know
much about multiple outputs as well :-)).

--
Alex

Re: [PATCH] gnu: Add mpv-minimal.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 972 bytes --]

On Thu, 24 Dec 2015 11:35:45 +0300
Alex Kost <alezost@gmail.com> wrote:

> Leo Famulari (2015-12-23 22:29 +0300) wrote:
> 
>  [...]  
>  [...]  
>  [...]  
> 
> I don't see how it can be done using a separate output (but I don't know
> much about multiple outputs as well :-)).
> 
> --
> Alex
> 

One build and two outputs, mpv and mpv-minimal, would be nice for a
substitution server but not be too helpful in the case of building your own
packages. I don't believe it would be possible.

off the top of my head for defining mpv-minimal in terms of mpv (see
python.scm for a lot more examples):

(define-public mpv-minimal
  (package (inherit mpv)
    (name "mpv-minimal)
    (inputs (alist-delete "samba" (package-inputs mpv)))))

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] gnu: Add mpv-minimal.

[Leo Famulari]

On Thu, Dec 24, 2015 at 03:56:00PM +0200, Efraim Flashner wrote:
> On Thu, 24 Dec 2015 11:35:45 +0300
> Alex Kost <alezost@gmail.com> wrote:
> One build and two outputs, mpv and mpv-minimal, would be nice for a
> substitution server but not be too helpful in the case of building your own
> packages. I don't believe it would be possible.
> 
> off the top of my head for defining mpv-minimal in terms of mpv (see
> python.scm for a lot more examples):
> 
> (define-public mpv-minimal
>   (package (inherit mpv)
>     (name "mpv-minimal)
>     (inputs (alist-delete "samba" (package-inputs mpv)))))
> 

I think Alex and Efraim are right, based on my very limited
understanding of multi-output packages.

Since I don't use mpv or samba, I don't have a stake in this. Feel free
to do whatever you decide.

> -- 
> Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
> GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
> Confidentiality cannot be guaranteed on emails sent or received unencrypted

Re: [PATCH] gnu: Add mpv-minimal.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]

On Wed, 23 Dec 2015 11:26:47 +0300
Alex Kost <alezost@gmail.com> wrote:

> Andreas Enge (2015-12-05 23:49 +0300) wrote:
> 
>  [...]  
>  [...]  
>  [...]  
> 
> I agree!
> 
> Mark H Weaver (2015-12-19 03:02 +0300) wrote:
> 
>  [...]  
>  [...]  
>  [...]  
> 
> I am an mpv user and I would really like to get rid of this samba
> output, as it is heavy-weight and IIUC the lost functionality would be
> an impossibility to play audio/video files from remote resources
> connected using samba (which most likely are "MS Windows" partitions).
> 
> So if other people do not object, I'm going to remove 'samba' output
> from 'mpv' package.
> 

I also use samba for my networking around my place. My wife needs windows for
her work, so I have our RPi/NAS set up to use samba instead of nfs.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] gnu: Add mpv-minimal.

[Alex Kost]

Efraim Flashner (2015-12-23 22:48 +0300) wrote:

> On Wed, 23 Dec 2015 11:26:47 +0300
> Alex Kost <alezost@gmail.com> wrote:
[...]
>> I am an mpv user and I would really like to get rid of this samba
>> output, as it is heavy-weight and IIUC the lost functionality would be
>> an impossibility to play audio/video files from remote resources
>> connected using samba (which most likely are "MS Windows" partitions).
>>
>> So if other people do not object, I'm going to remove 'samba' output
>> from 'mpv' package.
>
> I also use samba for my networking around my place. My wife needs windows for
> her work, so I have our RPi/NAS set up to use samba instead of nfs.

But do you need mpv built with samba support?  This thread is not about
samba package, but about removing samba output from 'mpv' package.  BTW
I don't insist on it, originally I suggested¹ to add 'mpv-minimal'
package, and I would be really happy with it rather then removing
functionality from 'mpv' package.

¹ <http://lists.gnu.org/archive/html/guix-devel/2015-12/msg00091.html>

--
Alex

Re: [PATCH] gnu: Add mpv-minimal.

[Efraim Flashner]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On December 24, 2015 10:36:42 AM GMT+02:00, Alex Kost <alezost@gmail.com> wrote:
>Efraim Flashner (2015-12-23 22:48 +0300) wrote:
>
>> On Wed, 23 Dec 2015 11:26:47 +0300
>> Alex Kost <alezost@gmail.com> wrote:
>[...]
>>> I am an mpv user and I would really like to get rid of this samba
>>> output, as it is heavy-weight and IIUC the lost functionality would
>be
>>> an impossibility to play audio/video files from remote resources
>>> connected using samba (which most likely are "MS Windows"
>partitions).
>>>
>>> So if other people do not object, I'm going to remove 'samba' output
>>> from 'mpv' package.
>>
>> I also use samba for my networking around my place. My wife needs
>windows for
>> her work, so I have our RPi/NAS set up to use samba instead of nfs.
>
>But do you need mpv built with samba support?  This thread is not about
>samba package, but about removing samba output from 'mpv' package.  BTW
>I don't insist on it, originally I suggested¹ to add 'mpv-minimal'
>package, and I would be really happy with it rather then removing
>functionality from 'mpv' package.
>
>¹ <http://lists.gnu.org/archive/html/guix-devel/2015-12/msg00091.html>
>
>--
>Alex

I don't know if this will top post but hopefully not.

I looked at the MPV github page and the syntax for MPV over built-in samba is 'mpv smb://user:password@host:/full/path/to/file.ext' and without tab completion and without support for .netrc or .smb.conf I would never do that. Once the directory is mounted locally it doesn't need samba to play networked content.

Now that I've looked at it more it seems samba support isn't really a useful feature for mpv.
- --
Sent from my Android device with K-9 Mail. Please excuse my brevity.
-----BEGIN PGP SIGNATURE-----

iQJFBAEBCgAvKBxFZnJhaW0gRmxhc2huZXIgPGVmcmFpbUBmbGFzaG5lci5jby5p
bD4FAlZ7t14ACgkQ9MHTkX6s7pOQuQ//aI73yzSm4GO6/EP/2sIIngXhCBZhMDqF
rYfmop89ONbKGSR4UdgfXW2TtkclyQGYJwp5egjZCsSDqTblirC4CAlz9PKLT2d8
RyRGa0mCWj3CjH9GcREfPPbjW9Ir4M6Jh+5qMvY1ewxWswHD6M0nJug/IiizY6Pj
ldUgYLD52nkexpLI39zI2MDCM3GYgUfWayVffrFVajRADyCFGgSlLNrqy+6rkp6w
pRZ4gxHquFBwxAE0lQXcFqoFRCDPu8MHz31PH0amna03616pVoOHrmkVyZculzPQ
9vxDVQLsqoip5bIO5YmAZsTMNDvxFmjqME1Hs013WLI4sfuonYXqqbLj0vscP/kr
RAXN9/4A3dhonwPlBkS0ltQmNwKT/QSIdpKjVW3f2cnfhyrGBdHC6gDQkiPvGYah
14jmiFQUstHviV4edn/vtWKG1KyWqU9GciddSRxhbVuB+Dj8wW3305uTDyHsrxoC
vQXOtcBj5rOFeXzlZmlb7etv7AbqB5Q8eiPf0AurMBJYh7PHaAKg5Mbl/06BY/AN
EGZHsxhToAMFdS0DGFF+MfA0dBZLgtMpKfssroCaWZ1faPasrO1KzEHL2DL/9Dmd
2GgQKy1kORcI3NEpx2/toxFH8VaPInzs1eNXSN8O7nT/PpNUQHOn2wwBVhrAdkDW
QVRGHkZ64W4=
=yA2G
-----END PGP SIGNATURE-----

Re: [PATCH] gnu: Add mpv-minimal.

[Alex Kost]

Efraim Flashner (2015-12-24 12:14 +0300) wrote:

[...]
> I looked at the MPV github page and the syntax for MPV over built-in
> samba is 'mpv smb://user:password@host:/full/path/to/file.ext' and
> without tab completion and without support for .netrc or .smb.conf I
> would never do that. Once the directory is mounted locally it doesn't
> need samba to play networked content.
>
> Now that I've looked at it more it seems samba support isn't really a
> useful feature for mpv.

Great news, thanks for looking at it!  Now this looks like a
not-very-common feature indeed.  I'll wait for other objections for a
week or so before removing 'samba' input from 'mpv' package (although I
would still prefer to have an 'mpv-minimal' package).

-- 
Alex

Re: [PATCH] gnu: Add mpv-minimal.

[Ludovic Courtès]

Alex Kost <alezost@gmail.com> skribis:

> Efraim Flashner (2015-12-24 12:14 +0300) wrote:
>
> [...]
>> I looked at the MPV github page and the syntax for MPV over built-in
>> samba is 'mpv smb://user:password@host:/full/path/to/file.ext' and
>> without tab completion and without support for .netrc or .smb.conf I
>> would never do that. Once the directory is mounted locally it doesn't
>> need samba to play networked content.
>>
>> Now that I've looked at it more it seems samba support isn't really a
>> useful feature for mpv.
>
> Great news, thanks for looking at it!  Now this looks like a
> not-very-common feature indeed.  I'll wait for other objections for a
> week or so before removing 'samba' input from 'mpv' package (although I
> would still prefer to have an 'mpv-minimal' package).

Either way (removing Samba from MPV’s dependencies, or adding an
‘mpv-minimal’ package) is fine with me.

Ludo’.

Re: [PATCH] gnu: Add mpv-minimal.

[Alex Kost]

Alex Kost (2015-12-25 18:29 +0300) wrote:

> Efraim Flashner (2015-12-24 12:14 +0300) wrote:
>
> [...]
>> I looked at the MPV github page and the syntax for MPV over built-in
>> samba is 'mpv smb://user:password@host:/full/path/to/file.ext' and
>> without tab completion and without support for .netrc or .smb.conf I
>> would never do that. Once the directory is mounted locally it doesn't
>> need samba to play networked content.
>>
>> Now that I've looked at it more it seems samba support isn't really a
>> useful feature for mpv.
>
> Great news, thanks for looking at it!  Now this looks like a
> not-very-common feature indeed.  I'll wait for other objections for a
> week or so before removing 'samba' input from 'mpv' package

Done in commit fbbaa4d.  Let's see if anyone will report about missing
feature :-)

-- 
Alex