unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH 0/1] Add some notes about setting up GuixSD filesystems
@ 2015-12-20  3:00 Leo Famulari
  2015-12-20  3:00 ` [PATCH 1/1] doc: Explain significance of partition labels Leo Famulari
  0 siblings, 1 reply; 4+ messages in thread
From: Leo Famulari @ 2015-12-20  3:00 UTC (permalink / raw)
  To: guix-devel

At least two people made the same mistake while installing GuixSD in the
last day: me and aeva on #guix both didn't realize that the device field
of the file-system configuration should match the label of the partition
it is describing. This leaves the system unbootable (fixable, but
unbootable).

This patch is an attempt to help users understand the relationship
between their partition labels and the GuixSD file-system configuration.

I adapted /etc/configuration/bare-bones.scm when I made the mistake. I'm
sure many users will adapt these example configurations for their first
installation, so these edits primarily address those users.

Thoughts?

Leo Famulari (1):
  doc: Explain significance of partition labels.

 doc/guix.texi | 7 +++++++
 1 file changed, 7 insertions(+)

-- 
2.6.2

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/1] doc: Explain significance of partition labels.
  2015-12-20  3:00 [PATCH 0/1] Add some notes about setting up GuixSD filesystems Leo Famulari
@ 2015-12-20  3:00 ` Leo Famulari
  2015-12-20 22:16   ` Ludovic Courtès
  0 siblings, 1 reply; 4+ messages in thread
From: Leo Famulari @ 2015-12-20  3:00 UTC (permalink / raw)
  To: guix-devel

* doc/guix.texi (Preparing for Installation): Point out relationship
between partition labels and the file-system configuration.
---
 doc/guix.texi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/doc/guix.texi b/doc/guix.texi
index 06d70ba..53a5fd3 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -5456,6 +5456,13 @@ reliably refer to them in @code{file-system} declarations (@pxref{File
 Systems}).  This is typically done using the @code{-L} option of
 @command{mkfs.ext4} and related commands.
 
+Be sure that your partition labels match the value of their respective
+@code{device} fields in your @code{file-system} configuration, if your
+@code{file-system} configuration sets the value of @code{title} to
+"label", as do the example configurations found on the USB installation
+image under @code{/etc/configuration} (@pxref{Using the Configuration
+System}).
+
 @c FIXME: Uncomment this once GRUB fully supports encrypted roots.
 @c A typical command sequence may be:
 @c
-- 
2.6.2

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] doc: Explain significance of partition labels.
  2015-12-20  3:00 ` [PATCH 1/1] doc: Explain significance of partition labels Leo Famulari
@ 2015-12-20 22:16   ` Ludovic Courtès
  2015-12-21  4:29     ` Leo Famulari
  0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2015-12-20 22:16 UTC (permalink / raw)
  To: Leo Famulari; +Cc: guix-devel

Leo Famulari <leo@famulari.name> skribis:

> * doc/guix.texi (Preparing for Installation): Point out relationship
> between partition labels and the file-system configuration.

[...]

> +Be sure that your partition labels match the value of their respective
> +@code{device} fields in your @code{file-system} configuration, if your
> +@code{file-system} configuration sets the value of @code{title} to
> +"label", as do the example configurations found on the USB installation

@code{'label}

> +image under @code{/etc/configuration} (@pxref{Using the Configuration

@file{/etc/configuration}

Otherwise LGTM!

I’ve noticed a number of people who had overlooked the comment in the
configuration examples, so this is a worthy addition.

I wonder if changing the label in the examples from “root” to
“my-root-partition” or similar wouldn’t make it less easily overlooked?

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] doc: Explain significance of partition labels.
  2015-12-20 22:16   ` Ludovic Courtès
@ 2015-12-21  4:29     ` Leo Famulari
  0 siblings, 0 replies; 4+ messages in thread
From: Leo Famulari @ 2015-12-21  4:29 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: guix-devel

On Sun, Dec 20, 2015 at 11:16:04PM +0100, Ludovic Courtès wrote:
> Leo Famulari <leo@famulari.name> skribis:
> 
> > * doc/guix.texi (Preparing for Installation): Point out relationship
> > between partition labels and the file-system configuration.
> 
> [...]
> 
> > +Be sure that your partition labels match the value of their respective
> > +@code{device} fields in your @code{file-system} configuration, if your
> > +@code{file-system} configuration sets the value of @code{title} to
> > +"label", as do the example configurations found on the USB installation
> 
> @code{'label}
> 
> > +image under @code{/etc/configuration} (@pxref{Using the Configuration
> 
> @file{/etc/configuration}
> 
> Otherwise LGTM!

I fixed those.

> I’ve noticed a number of people who had overlooked the comment in the
> configuration examples, so this is a worthy addition.
> 
> I wonder if changing the label in the examples from “root” to
> “my-root-partition” or similar wouldn’t make it less easily overlooked?

Done in the updated patch.

> 
> Thanks,
> Ludo’.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-12-21  4:29 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-20  3:00 [PATCH 0/1] Add some notes about setting up GuixSD filesystems Leo Famulari
2015-12-20  3:00 ` [PATCH 1/1] doc: Explain significance of partition labels Leo Famulari
2015-12-20 22:16   ` Ludovic Courtès
2015-12-21  4:29     ` Leo Famulari

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).