From: Leo Famulari <leo@famulari.name>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/1] doc: Explain significance of partition labels.
Date: Sun, 20 Dec 2015 23:29:16 -0500 [thread overview]
Message-ID: <20151221042916.GA17705@jasmine> (raw)
In-Reply-To: <87y4cosr4r.fsf@gnu.org>
On Sun, Dec 20, 2015 at 11:16:04PM +0100, Ludovic Courtès wrote:
> Leo Famulari <leo@famulari.name> skribis:
>
> > * doc/guix.texi (Preparing for Installation): Point out relationship
> > between partition labels and the file-system configuration.
>
> [...]
>
> > +Be sure that your partition labels match the value of their respective
> > +@code{device} fields in your @code{file-system} configuration, if your
> > +@code{file-system} configuration sets the value of @code{title} to
> > +"label", as do the example configurations found on the USB installation
>
> @code{'label}
>
> > +image under @code{/etc/configuration} (@pxref{Using the Configuration
>
> @file{/etc/configuration}
>
> Otherwise LGTM!
I fixed those.
> I’ve noticed a number of people who had overlooked the comment in the
> configuration examples, so this is a worthy addition.
>
> I wonder if changing the label in the examples from “root” to
> “my-root-partition” or similar wouldn’t make it less easily overlooked?
Done in the updated patch.
>
> Thanks,
> Ludo’.
prev parent reply other threads:[~2015-12-21 4:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-20 3:00 [PATCH 0/1] Add some notes about setting up GuixSD filesystems Leo Famulari
2015-12-20 3:00 ` [PATCH 1/1] doc: Explain significance of partition labels Leo Famulari
2015-12-20 22:16 ` Ludovic Courtès
2015-12-21 4:29 ` Leo Famulari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151221042916.GA17705@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).